Bug 1398860

Summary:	Missing dependency on socket rhel-push-plugin.socket
Product:	[Fedora] Fedora	Reporter:	Lukas Slebodnik <lslebodn>
Component:	docker	Assignee:	Antonio Murdaca <amurdaca>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	26	CC:	adimania, admiller, amurdaca, dwalsh, ichavero, jcajka, jchaloup, lsm5, marianne, miminar, nalin, riek, rlpowell, vbatts
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-03 10:31:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Lukas Slebodnik 2016-11-26 17:50:15 UTC

Description of problem:
It is not possible to start docker after the last upgrade.

Version-Release number of selected component (if applicable):
sh# rpm -q docker docker-rhel-push-plugin docker-unit-test
docker-1.12.3-22.git7b5044b.fc26.x86_64
package docker-rhel-push-plugin is not installed
package docker-unit-test is not installed

sh# rpm -qa "docker*"
docker-1.12.3-22.git7b5044b.fc26.x86_64
docker-common-1.12.3-22.git7b5044b.fc26.x86_64

How reproducible:
Deterministic

Steps to Reproduce:
1. //upgrade to latest docker in rawhide
   dnf upgrade -y docker
2. //restart docker service
   systemctl stop docker
   systemctl start docker

Actual results:
Failed to start docker.service: Unit rhel-push-plugin.socket not found.

Expected results:
The service is restarted without any problem.

Additional info:
Docker service file has stric dependency on rhel-push-plugin.socket
but there isn't any dependency on rpm provided such socket

systemctl cat docker.service | grep Requires
Requires=docker-containerd.service rhel-push-plugin.socket

sh# dnf provides */rhel-push-plugin.socket
Last metadata expiration check: 0:22:57 ago on Sat Nov 26 18:15:47 2016 CET.
docker-rhel-push-plugin-2:1.12.3-22.git7b5044b.fc26.x86_64 : Avoids pushing a RHEL-based image to docker.io registry
Repo        : rawhide

docker-unit-test-2:1.12.3-22.git7b5044b.fc26.x86_64 : A golang registry for global request variables (source libraries) - for running unit tests
Repo        : rawhide

Comment 1 Lukas Slebodnik 2016-11-26 18:06:51 UTC

See also BZ1398861

Comment 2 Antonio Murdaca 2016-11-26 18:13:36 UTC

Lokesh, have you seen this one? I think it's related to what we did with plugins in rawhide

Comment 3 Antonio Murdaca 2016-11-27 11:13:18 UTC

*** Bug 1398900 has been marked as a duplicate of this bug. ***

Comment 4 Daniel Walsh 2016-11-27 12:01:20 UTC

9de00853d884e47bae70ea6bc8b87ce1b4a2bab2 should fix this labeling issue in container-selinux package.

Can you push a new docker package with this fix.

Comment 5 Fedora End Of Life 2017-02-28 10:40:02 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 6 Fedora End Of Life 2018-05-03 08:00:11 UTC

This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 7 Lukas Slebodnik 2018-05-03 10:31:03 UTC

Works for me now

sh# rpm -q --requires docker | grep push
docker-rhel-push-plugin = 2:1.13.1-44.git584d391.fc26

sh# rpm -ql docker-rhel-push-plugin | grep socket
/usr/lib/systemd/system/rhel-push-plugin.socket