Bug 1399005

Summary: [GSS](6.4.z) No logging output when hitting maxSwallowSize
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Masafumi Miura <mmiura>
Component: WebAssignee: Petr Jurak <pjurak>
Status: CLOSED CURRENTRELEASE QA Contact: Radim Hatlapatka <rhatlapa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.4.7CC: aogburn, bmaxwell, mcada, mmiura, msochure, pjurak, rmaucher, tanabe.yoshimasa
Target Milestone: CR1   
Target Release: EAP 6.4.14   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-23 08:21:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1401452, 1405311    
Attachments:
Description Flags
fileupload example application
none
JBOSSWEB_endRequest_IOException_logging.patch
none
JBOSSWEB_maxSwallowSizeExceeded_logging.patch none

Description Masafumi Miura 2016-11-28 03:32:00 UTC 
Created attachment 1225097 [details]
fileupload example application

Description of problem:
A new parameter maxSwallowSize (org.apache.coyote.MAX_SWALLOW_SIZE) was introduced since EAP 6.4.7 by BZ#1236910. Some fileupload application fails silently when hitting the parameter. There's no logging out in server.log even if we increase logging level of JBossWeb. Please improve logging output to make investigation easily and for end user to know they are hitting the parameter.

Version-Release number of selected component (if applicable):
JBOSSWEB_7_5_15_FINAL or later

How reproducible:
Anytime when hitting maxSwallowSize

Steps to Reproduce:
1. Deploy an attached example: spring-fileupload.war
2. Access http://localhost:8080/spring-fileupload/
3. Upload a large file than 2MB (default value of maxSwallowSize)
You will see "connection reset" error page of browser as expected.

Actual results:
No log message was output in server.log even if increasing JBossWeb logging level to TRACE 

Expected results:
A log message "Maximum swallow size is exceeded" should be output in server.log

Additional info:
IdentityInputFilter and ChunkedInputFilter throw IOException with a log message "Maximum swallow size is exceeded" but Http11(|Nio|Apr)Processor never output the log message when catching the IOException.
Comment 1 Masafumi Miura 2016-11-28 03:34:50 UTC 
Created attachment 1225098 [details]
JBOSSWEB_endRequest_IOException_logging.patch
Comment 2 Masafumi Miura 2016-11-28 03:35:31 UTC 
Created attachment 1225099 [details]
JBOSSWEB_maxSwallowSizeExceeded_logging.patch
Comment 3 Masafumi Miura 2016-11-28 03:39:33 UTC 
I have two proposed patches. I'm not sure which one is better.

 - JBOSSWEB_endRequest_IOException_logging.patch
   This will add DEBUG level logging when catching IOException in Http11(|Nio|Apr)Processor#end().

 - JBOSSWEB_maxSwallowSizeExceeded_logging.patch
   This will add DEBUG level logging when detecting maxSwallowSize exceeded inside IdentityInputFilter and ChunkedInputFilter.
Comment 11 Michael Cada 2017-02-22 15:26:00 UTC 
Verified with EAP 6.4.14.CP.CR1
Comment 13 Petr Penicka 2017-03-23 08:21:00 UTC 
Released with EAP 6.4.14 on March 14 (ZIPs) and March 22 (RPMs).