Bug 1399031

Summary: build: add systemd dependency to glusterfs sub-package
Product: [Community] GlusterFS Reporter: Milind Changire <mchangir>
Component: buildAssignee: Milind Changire <mchangir>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.10.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1400635 (view as bug list) Environment:
Last Closed: 2017-03-06 17:36:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1377062, 1400635    

Description Milind Changire 2016-11-28 06:12:20 UTC
Description of problem:
glusterfs.spec.in refers to /bin/systemctl
This is not the path that systemctl is found in.
It is found at /usr/bin
Also, its not a good practice to refer to utilities with their absolute paths.

Additional info:
The absolute path will now be changed to %{_bindir}/systemctl

Comment 1 Milind Changire 2016-11-28 06:17:23 UTC
Correction:
systemctl will be referred to with just the base name and without any path prefix.

Comment 2 Worker Ant 2016-11-28 06:20:11 UTC
REVIEW: http://review.gluster.org/15936 (build: remove absolute paths to systemctl) posted (#1) for review on master by Milind Changire (mchangir)

Comment 3 Worker Ant 2016-11-28 09:16:30 UTC
REVIEW: http://review.gluster.org/15936 (build: remove absolute paths to systemctl) posted (#2) for review on master by Milind Changire (mchangir)

Comment 4 Worker Ant 2016-11-29 15:58:14 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the primary package) posted (#3) for review on master by Milind Changire (mchangir)

Comment 5 Worker Ant 2016-11-29 16:00:28 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the primary package) posted (#4) for review on master by Milind Changire (mchangir)

Comment 6 Worker Ant 2016-11-30 08:53:02 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the glusterfs sub-package) posted (#5) for review on master by Milind Changire (mchangir)

Comment 7 Worker Ant 2016-11-30 11:52:00 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the glusterfs sub-package) posted (#6) for review on master by Milind Changire (mchangir)

Comment 8 Worker Ant 2016-11-30 14:12:03 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the glusterfs sub-package) posted (#7) for review on master by Milind Changire (mchangir)

Comment 9 Worker Ant 2016-12-01 12:39:57 UTC
REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the glusterfs sub-package) posted (#8) for review on master by Milind Changire (mchangir)

Comment 10 Worker Ant 2016-12-01 14:56:49 UTC
COMMIT: http://review.gluster.org/15936 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 6138f4a2fc835bc94aa66543f5aee4f92081f1c7
Author: Milind Changire <mchangir>
Date:   Wed Nov 30 19:38:03 2016 +0530

    build: add systemd dependency to the glusterfs sub-package
    
    Problem:
    /bin/systemctl is not available at install time of primary glusterfs
    package.
    
    Solution:
    Add %{?systemd_requires} to the glusterfs sub-package install time
    requirements.
    
    Replace all "Requires: systemd" and "Requires: systemd-units" with
    %{?systemd_requires}. %systemd_requires is defined in
    /usr/lib/rpm/macros.d/macros.systemd
    systemd-units is provided by systemd.
    Add BuildRequires: systemd for the definition of %systemd_requires
    as well.
    
    Change-Id: I980ece7d538ea177ca6b0e70c1c169e6f04c46d4
    BUG: 1399031
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: http://review.gluster.org/15936
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>
    Smoke: Gluster Build System <jenkins.org>

Comment 11 Shyamsundar 2017-03-06 17:36:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/