Bug 1399068

Description of problem:

'hosted-engine --upgrade-appliance' should behave similarly to engine-setup downstream, which points users at the upgrade helper and the installation guide.

See also bug 1112259.

This comment was originaly posted by didi

Description of problem:

'hosted-engine --upgrade-appliance' should behave similarly to engine-setup downstream, which points users at the upgrade helper and the installation guide.

See also bug 1112259.

This comment was originaly posted by didi

Can I kindly ask for reproduction steps for the bug?
I'm not sure on how it should be verified.

This comment was originaly posted by nsednev

(In reply to Nikolai Sednev from comment #11)
> Can I kindly ask for reproduction steps for the bug?
> I'm not sure on how it should be verified.

Downstream engine-setup does:

      Welcome to the RHEV 4.0 setup/upgrade.
      Please read the RHEV 4.0 install guide
      https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/4.0/html/Installation_Guide/index.html.
      Please refer to the RHEV Upgrade Helper application
      https://access.redhat.com/labs/rhevupgradehelper/ which will guide you in the upgrading process.
      Would you like to proceed? (Yes, No) [Yes]: 

hosted-engine --upgrade-appliance also outputs some text, but does not mention the upgrade helper. IMO Downstream it should.

This comment was originaly posted by didi

(In reply to Yedidyah Bar David from comment #12)
> (In reply to Nikolai Sednev from comment #11)
> > Can I kindly ask for reproduction steps for the bug?
> > I'm not sure on how it should be verified.
> 
> Downstream engine-setup does:
> 
>       Welcome to the RHEV 4.0 setup/upgrade.
>       Please read the RHEV 4.0 install guide
>      
> https://access.redhat.com/site/documentation/en-US/
> Red_Hat_Enterprise_Virtualization/4.0/html/Installation_Guide/index.html.
>       Please refer to the RHEV Upgrade Helper application
>       https://access.redhat.com/labs/rhevupgradehelper/ which will guide you
> in the upgrading process.
>       Would you like to proceed? (Yes, No) [Yes]: 
> 
> hosted-engine --upgrade-appliance also outputs some text, but does not
> mention the upgrade helper. IMO Downstream it should.

This is too late we want to add this to the backup stage of 3.6.z.

This comment was originaly posted by ydary

(In reply to Yaniv Dary from comment #13)
> (In reply to Yedidyah Bar David from comment #12)
> > (In reply to Nikolai Sednev from comment #11)
> > > Can I kindly ask for reproduction steps for the bug?
> > > I'm not sure on how it should be verified.
> > 
> > Downstream engine-setup does:
> > 
> >       Welcome to the RHEV 4.0 setup/upgrade.
> >       Please read the RHEV 4.0 install guide
> >      
> > https://access.redhat.com/site/documentation/en-US/
> > Red_Hat_Enterprise_Virtualization/4.0/html/Installation_Guide/index.html.
> >       Please refer to the RHEV Upgrade Helper application
> >       https://access.redhat.com/labs/rhevupgradehelper/ which will guide you
> > in the upgrading process.
> >       Would you like to proceed? (Yes, No) [Yes]: 
> > 
> > hosted-engine --upgrade-appliance also outputs some text, but does not
> > mention the upgrade helper. IMO Downstream it should.
> 
> This is too late we want to add this to the backup stage of 3.6.z.

Why too late? backup runs later than that.

This comment was originaly posted by didi

(In reply to Yedidyah Bar David from comment #14)
> (In reply to Yaniv Dary from comment #13)
> > (In reply to Yedidyah Bar David from comment #12)
> > > (In reply to Nikolai Sednev from comment #11)
> > > > Can I kindly ask for reproduction steps for the bug?
> > > > I'm not sure on how it should be verified.
> > > 
> > > Downstream engine-setup does:
> > > 
> > >       Welcome to the RHEV 4.0 setup/upgrade.
> > >       Please read the RHEV 4.0 install guide
> > >      
> > > https://access.redhat.com/site/documentation/en-US/
> > > Red_Hat_Enterprise_Virtualization/4.0/html/Installation_Guide/index.html.
> > >       Please refer to the RHEV Upgrade Helper application
> > >       https://access.redhat.com/labs/rhevupgradehelper/ which will guide you
> > > in the upgrading process.
> > >       Would you like to proceed? (Yes, No) [Yes]: 
> > > 
> > > hosted-engine --upgrade-appliance also outputs some text, but does not
> > > mention the upgrade helper. IMO Downstream it should.
> > 
> > This is too late we want to add this to the backup stage of 3.6.z.
> 
> Why too late? backup runs later than that.

Don't you run backup, restore and only then run the setup?

This comment was originaly posted by ydary

(In reply to Yaniv Dary from comment #15)
> (In reply to Yedidyah Bar David from comment #14)
> > (In reply to Yaniv Dary from comment #13)
> > > (In reply to Yedidyah Bar David from comment #12)
> > > > (In reply to Nikolai Sednev from comment #11)
> > > > > Can I kindly ask for reproduction steps for the bug?
> > > > > I'm not sure on how it should be verified.
> > > > 
> > > > Downstream engine-setup does:
> > > > 
> > > >       Welcome to the RHEV 4.0 setup/upgrade.
> > > >       Please read the RHEV 4.0 install guide
> > > >      
> > > > https://access.redhat.com/site/documentation/en-US/
> > > > Red_Hat_Enterprise_Virtualization/4.0/html/Installation_Guide/index.html.
> > > >       Please refer to the RHEV Upgrade Helper application
> > > >       https://access.redhat.com/labs/rhevupgradehelper/ which will guide you
> > > > in the upgrading process.
> > > >       Would you like to proceed? (Yes, No) [Yes]: 
> > > > 
> > > > hosted-engine --upgrade-appliance also outputs some text, but does not
> > > > mention the upgrade helper. IMO Downstream it should.
> > > 
> > > This is too late we want to add this to the backup stage of 3.6.z.
> > 
> > Why too late? backup runs later than that.
> 
> Don't you run backup, restore and only then run the setup?

This bug refers to "The HE upgrade tool". The flow with this tool is:
1. You add a 4.0 host (so that you can have the tool)
2. You run it
3. It tells you to run engine-backup on your old engine machine and copy the result to current machine, and prompts for the backup file name
4. Then it continues

So it should be enough to point at the upgrade helper at stage (2.).

Assuming that bug 1397409 refers to upgrade of a standalone engine, above does not apply there. So we do need both, and with final flow of current bug the user will be notified twice (which might be a bit annoying, but harmless).

This comment was originaly posted by didi

Verified on ovirt-hosted-engine-setup-2.1.0.2-1.el7ev.noarch


Upgrade process:
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          During customization use CTRL-D to abort.
         
          ==================================================================================
          Welcome to the oVirt Self Hosted Engine setup/Upgrade tool.
         
          Please refer to the oVirt install guide:
          https://www.ovirt.org/documentation/how-to/hosted-engine/#fresh-install
          Please refer to the oVirt upgrade guide:
          https://www.ovirt.org/documentation/how-to/hosted-engine/#upgrade-hosted-engine
          ==================================================================================
          Continuing will upgrade the engine VM running on this hosts deploying and configuring a new appliance.
          If your engine VM is already based on el7 you can also simply upgrade the engine there.
          This procedure will create a new disk on the hosted-engine storage domain and it will backup there the content of your current engine VM disk.
          The new el7 based appliance will be deployed over the existing disk destroying its content; at any time you will be able to rollback using the content of the backup disk.
          You will be asked to take a backup of the running engine and copy it to this host.
          The engine backup will be automatically injected and recovered on the new appliance.
          Are you sure you want to continue? (Yes, No)[Yes]: 


Rollback process:
# hosted-engine --rollback-upgrade
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          During customization use CTRL-D to abort.
          ====================================================================================================
          Welcome to the oVirt Self Hosted Engine - Appliance Migration/Rollback.
         
          Please refer to the Rollback guide:
          https://www.ovirt.org/develop/release-management/features/hosted-engine-migration-to-4-0/#rollback
          ====================================================================================================
          Continuing will rollback the engine VM from a previous upgrade attempt.
          This procedure will restore an engine VM image from a backup taken during an upgrade attempt.
          The result of any action occurred after the backup creation instant could be definitively lost.
          Are you sure you want to continue? (Yes, No)[Yes]:

Verified on correct version
# rpm -qa | grep hosted
ovirt-hosted-engine-setup-2.0.4.3-2.el7ev.noarch
ovirt-hosted-engine-ha-2.0.7-2.el7ev.noarch

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0543.html