Bug 1399130

Summary:	SEEK_HOLE/ SEEK_DATA doesn't return the correct offset
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	protocol	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1398076	Environment:
Last Closed:	2016-12-14 07:12:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1398076, 1399131
Bug Blocks:

Description Ravishankar N 2016-11-28 10:48:22 UTC

+++ This bug was initially created as a clone of Bug #1398076 +++

Description of problem:
Found while testing the downstream kernel with FUSE support for seek_hole/data that we always get zero as the offset when we try these flags.

--- Additional comment from Worker Ant on 2016-11-23 23:02:29 EST ---

REVIEW: http://review.gluster.org/15920 (protocol/server: capute offset in seek) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2016-11-26 10:37:08 EST ---

REVIEW: http://review.gluster.org/15920 (protocol/server: capture offset in seek) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2016-11-28 05:33:14 EST ---

COMMIT: http://review.gluster.org/15920 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit cc37e5929d1e3ea4eaf4c4576a82066bf131ad05
Author: Ravishankar N <ravishankar>
Date:   Thu Nov 24 08:31:47 2016 +0530

    protocol/server: capture offset in seek
    
    Problem:
    http://review.gluster.org/11482 implemented seek FOP but
    http://review.gluster.org/#/c/14137/ 'undid' the change where we pack
    the offset returned by seek in server xlator before sending it to the client.
    As a result, seek always returns zero to the client for SEEK_HOLE/
    SEEK_DATA.
    
    Fix:
    I think 14137 removed it unintentionally, hence adding it back again.
    
    Signed-off-by: Ravishankar N <ravishankar>
    Change-Id: I67a1f7b53214b043c5291f5704be4a50b698f91c
    BUG: 1398076
    Reviewed-on: http://review.gluster.org/15920
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Worker Ant 2016-11-28 10:50:41 UTC

REVIEW: http://review.gluster.org/15943 (protocol/server: capture offset in seek) posted (#1) for review on release-3.8 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2016-11-29 08:46:48 UTC

COMMIT: http://review.gluster.org/15943 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit 31927cd4db62b338f4763ce00ab512d20e4d8c32
Author: Ravishankar N <ravishankar>
Date:   Thu Nov 24 08:31:47 2016 +0530

    protocol/server: capture offset in seek
    
    Problem:
    http://review.gluster.org/11482 implemented seek FOP but
    http://review.gluster.org/#/c/14137/ 'undid' the change where we pack
    the offset returned by seek in server xlator before sending it to the client.
    As a result, seek always returns zero to the client for SEEK_HOLE/
    SEEK_DATA.
    
    Fix:
    I think 14137 removed it unintentionally, hence adding it back again.
    
    
    > Reviewed-on: http://review.gluster.org/15920
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    
    (cherry picked from commit cc37e5929d1e3ea4eaf4c4576a82066bf131ad05)
    Signed-off-by: Ravishankar N <ravishankar>
    Change-Id: I67a1f7b53214b043c5291f5704be4a50b698f91c
    BUG: 1399130
    Reviewed-on: http://review.gluster.org/15943
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Niels de Vos 2016-12-14 07:12:39 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.7, please open a new bug report.

glusterfs-3.8.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-December/000226.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 4 Worker Ant 2016-12-21 23:21:10 UTC

REVIEW: http://review.gluster.org/16242 (protocol/server: capture offset in seek) posted (#1) for review on release-3.8-fb by Kevin Vigor (kvigor)