Bug 1399325

Summary: Right clicking address bar crashes epiphany
Product: [Fedora] Fedora Reporter: Štefan Gurský <scorpy_sk>
Component: epiphanyAssignee: Michael Catanzaro <mcatanzaro+wrong-account-do-not-cc>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: gecko-bugs-nobody, mcatanzaro+wrong-account-do-not-cc, rob.townley, scorpy_sk, tpopela
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-28 20:12:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Štefan Gurský 2016-11-28 18:30:52 UTC 
Description of problem:
When I do right click in address bar, epiphany crashes.

Version-Release number of selected component (if applicable):
Name        : epiphany
Epoch       : 1
Version     : 3.22.1
Release     : 1.fc25
Architecture: x86_64


Steps to Reproduce:
1. run epiphany
2. right click address bar
3. observe crash

Actual results:
SIGSEGV

Expected results:
displayed context menu

Additional info:

GNU gdb (GDB) Fedora 7.12-29.fc25
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from epiphany...Reading symbols from /usr/lib/debug/usr/bin/epiphany.debug...done.
done.
(gdb) run
Starting program: /usr/bin/epiphany 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7fffe007f700 (LWP 18389)]
[New Thread 0x7fffd8858700 (LWP 18390)]
[New Thread 0x7fffd3fff700 (LWP 18391)]
[New Thread 0x7fffd37fe700 (LWP 18392)]
[New Thread 0x7fffcaa6a700 (LWP 18393)]
Detaching after fork from child process 18394.
[New Thread 0x7fffca269700 (LWP 18396)]
[New Thread 0x7fffc9a68700 (LWP 18397)]
[New Thread 0x7fffc8bdb700 (LWP 18401)]
[New Thread 0x7fff83ffd700 (LWP 18402)]
[New Thread 0x7fff837fc700 (LWP 18403)]
Detaching after fork from child process 18404.
[New Thread 0x7fff82b8a700 (LWP 18413)]
[New Thread 0x7fff82389700 (LWP 18414)]
[New Thread 0x7fff81b88700 (LWP 18415)]
[New Thread 0x7fff81387700 (LWP 18416)]
[New Thread 0x7fff80b86700 (LWP 18421)]
[Thread 0x7fff82b8a700 (LWP 18413) exited]
[New Thread 0x7fff82b8a700 (LWP 18428)]
[New Thread 0x7fff53bff700 (LWP 18429)]
[New Thread 0x7fff533fe700 (LWP 18430)]
[New Thread 0x7fff52bfd700 (LWP 18431)]
[New Thread 0x7fff523fc700 (LWP 18432)]
[New Thread 0x7fff51bfb700 (LWP 18433)]
[New Thread 0x7fff513fa700 (LWP 18434)]
[New Thread 0x7fff50bf9700 (LWP 18435)]
[New Thread 0x7fff4bfff700 (LWP 18436)]
[Thread 0x7fff4bfff700 (LWP 18436) exited]
[Thread 0x7fff513fa700 (LWP 18434) exited]
[Thread 0x7fff51bfb700 (LWP 18433) exited]
[Thread 0x7fff533fe700 (LWP 18430) exited]
[Thread 0x7fff53bff700 (LWP 18429) exited]
[Thread 0x7fff52bfd700 (LWP 18431) exited]
[Thread 0x7fff523fc700 (LWP 18432) exited]
[Thread 0x7fff82389700 (LWP 18414) exited]
[Thread 0x7fff50bf9700 (LWP 18435) exited]
[Thread 0x7fff82b8a700 (LWP 18428) exited]
[Thread 0x7fff80b86700 (LWP 18421) exited]

Thread 1 "epiphany" received signal SIGSEGV, Segmentation fault.
g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x7ffff20337c1 <gtk_menu_real_insert+161>, 
    fundamental_type=fundamental_type@entry=80) at gtype.c:4024
4024	  node = lookup_type_node_I (type_instance->g_class->g_type);
Missing separate debuginfos, use: dnf debuginfo-install gnutls-3.5.6-1.fc25.x86_64
(gdb) bt
#0  g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x7ffff20337c1 <gtk_menu_real_insert+161>, 
    fundamental_type=fundamental_type@entry=80) at gtype.c:4024
#1  0x00007ffff0285bda in g_object_bind_property_full (source=source@entry=0x7ffff20337c1 <gtk_menu_real_insert+161>, 
    source_property=source_property@entry=0x5555555eb583 "sensitive", target=target@entry=0x555557628bd0, 
    target_property=target_property@entry=0x5555555eb583 "sensitive", flags=flags@entry=G_BINDING_SYNC_CREATE, transform_to=transform_to@entry=0x0, 
    transform_from=0x0, user_data=0x0, notify=0x0) at gbinding.c:831
#2  0x00007ffff0285fe2 in g_object_bind_property (source=source@entry=0x7ffff20337c1 <gtk_menu_real_insert+161>, 
    source_property=source_property@entry=0x5555555eb583 "sensitive", target=target@entry=0x555557628bd0, 
    target_property=target_property@entry=0x5555555eb583 "sensitive", flags=flags@entry=G_BINDING_SYNC_CREATE) at gbinding.c:1007
#3  0x00005555555c5b5f in entry_populate_popup_cb (entry=<optimized out>, menu=menu@entry=0x5555558feb50, lentry=0x5555561822a0)
    at ephy-location-entry.c:660
#4  0x00007ffff028c470 in g_cclosure_marshal_VOID__OBJECTv (closure=0x5555561bd9d0, return_value=<optimized out>, instance=0x5555561822a0, 
    args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x55555616be90) at gmarshal.c:2102
#5  0x00007ffff0289614 in _g_closure_invoke_va (closure=closure@entry=0x5555561bd9d0, return_value=return_value@entry=0x0, 
    instance=instance@entry=0x5555561822a0, args=args@entry=0x7fffffffd420, n_params=<optimized out>, param_types=0x55555616be90) at gclosure.c:867
#6  0x00007ffff02a3dd9 in g_signal_emit_valist (instance=0x5555561822a0, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7fffffffd420)
    at gsignal.c:3300
#7  0x00007ffff02a443f in g_signal_emit (instance=instance@entry=0x5555561822a0, signal_id=<optimized out>, detail=detail@entry=0) at gsignal.c:3447
#8  0x00007ffff1f9d1d5 in popup_targets_received (clipboard=<optimized out>, data=data@entry=0x7fffffffdab0, 
    user_data=user_data@entry=0x555557662a40) at gtkentry.c:9501
#9  0x00007ffff219a209 in selection_received (widget=0x55555595bd30, selection_data=0x7fffffffdab0, time=<optimized out>) at gtkclipboard.c:960
#10 0x00007ffff02893e5 in g_closure_invoke (closure=0x555557c61fd0, return_value=return_value@entry=0x0, n_param_values=3, 
    param_values=param_values@entry=0x7fffffffd740, invocation_hint=invocation_hint@entry=0x7fffffffd6c0) at gclosure.c:804
#11 0x00007ffff029b432 in signal_emit_unlocked_R (node=node@entry=0x5555558abd40, detail=detail@entry=0, instance=instance@entry=0x55555595bd30, 
    emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffd740) at gsignal.c:3635
#12 0x00007ffff02a405f in g_signal_emit_valist (instance=instance@entry=0x55555595bd30, signal_id=signal_id@entry=95, detail=detail@entry=0, 
    var_args=var_args@entry=0x7fffffffd978) at gsignal.c:3391
#13 0x00007ffff02a48eb in g_signal_emit_by_name (instance=0x55555595bd30, detailed_signal=detailed_signal@entry=0x7ffff221f764 "selection-received")
    at gsignal.c:3487
#14 0x00007ffff20b1d83 in gtk_selection_retrieval_report (info=info@entry=0x55555772b070, type=<optimized out>, format=<optimized out>, 
    buffer=<optimized out>, length=length@entry=56, time=0) at gtkselection.c:3031
#15 0x00007ffff20b5e0d in _gtk_selection_notify (widget=<optimized out>, event=0x555557721bc0) at gtkselection.c:2835
#16 0x00007ffff2025191 in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x5555558addb0, return_value=0x7fffffffdd20, instance=0x55555595bd30, 
    args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x5555558a9c30) at gtkmarshalers.c:131
#17 0x00007ffff0289614 in _g_closure_invoke_va (closure=closure@entry=0x5555558addb0, return_value=return_value@entry=0x7fffffffdd20, 
    instance=instance@entry=0x55555595bd30, args=args@entry=0x7fffffffddf0, n_params=<optimized out>, param_types=0x5555558a9c30) at gclosure.c:867
#18 0x00007ffff02a38b3 in g_signal_emit_valist (instance=0x55555595bd30, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7fffffffddf0)
    at gsignal.c:3300
---Type <return> to continue, or q <return> to quit---
#19 0x00007ffff02a443f in g_signal_emit (instance=instance@entry=0x55555595bd30, signal_id=<optimized out>, detail=detail@entry=0) at gsignal.c:3447
#20 0x00007ffff21719cc in gtk_widget_event_internal (widget=0x55555595bd30, event=0x555557721bc0) at gtkwidget.c:7721
#21 0x00007ffff20240c4 in gtk_main_do_event (event=0x555557721bc0) at gtkmain.c:1830
#22 0x00007ffff1b3b485 in _gdk_event_emit (event=event@entry=0x555557721bc0) at gdkevents.c:73
#23 0x00007ffff1b96e02 in gdk_event_source_dispatch (base=<optimized out>, callback=<optimized out>, data=<optimized out>) at gdkeventsource.c:118
#24 0x00007fffeffb0e42 in g_main_dispatch (context=0x555555868050) at gmain.c:3203
#25 g_main_context_dispatch (context=context@entry=0x555555868050) at gmain.c:3856
#26 0x00007fffeffb11c0 in g_main_context_iterate (context=context@entry=0x555555868050, block=block@entry=1, dispatch=dispatch@entry=1, 
    self=<optimized out>) at gmain.c:3929
#27 0x00007fffeffb126c in g_main_context_iteration (context=context@entry=0x555555868050, may_block=may_block@entry=1) at gmain.c:3990
#28 0x00007ffff0569bbd in g_application_run (application=0x5555558df230, argc=1, argv=0x7fffffffe258) at gapplication.c:2381
#29 0x00005555555867a4 in main (argc=<optimized out>, argv=<optimized out>) at ephy-main.c:495
Comment 1 Michael Catanzaro 2016-11-28 19:30:09 UTC 
Could you please get the backtrace with 'bt full' and post it again? Also, are you running under X11 or Wayland? Does it happen always for you? (I can't seem to reproduce.) Are you clicking anywhere in the title bar, or just in the white portion of the address bar inside the title bar with the favicon and lock icon?
Comment 2 Michael Catanzaro 2016-11-28 19:36:17 UTC 
OK I know what this is, there is a bug in the translation for your locale which is "fixed" by https://git.gnome.org/browse/epiphany/commit/lib/widgets/ephy-location-entry.c?id=fc05345d0d7acde7bb7208159bca39783937e50e

What locale are you using?
Comment 3 Michael Catanzaro 2016-11-28 20:12:31 UTC 
OK, this will be fixed in 3.22.4, most likely will be released and reach Fedora sometime in December. In the meantime, your workaround is to run it in a terminal with a different LANG set if you don't want to remember to not use this context menu (e.g. "$ LANG=en_US.utf8 epiphany"). Thanks for reporting!
Comment 4 Michael Catanzaro 2016-11-28 20:13:59 UTC 
Just for the record, fix is https://git.gnome.org/browse/epiphany/commit/lib/widgets/ephy-location-entry.c?id=660f4616caed40456556f52b4c24a6003d17901b