Bug 1399332

Summary: nova image-list is deprecated, but it should work even now
Product: Red Hat OpenStack Reporter: Stephen Gordon <sgordon>
Component: python-openstackclientAssignee: Artom Lifshitz <alifshit>
Status: CLOSED NEXTRELEASE QA Contact: Shai Revivo <srevivo>
Severity: high Docs Contact:
Priority: high    
Version: 10.0 (Newton)CC: alifshit, apevec, jdonohue, jpichon, lhh, sclewis, sgordon, srevivo
Target Milestone: ---Keywords: ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-03 20:10:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1233920, 1335596, 1399653    

Description Stephen Gordon 2016-11-28 18:55:21 UTC
Cloned from launchpad bug 1630161.

Description:

On newton it looks like:
$ nova image-list
WARNING: Command image-list is deprecated and will be removed after Nova 15.0.0 is released. Use python-glanceclient or openstackclient instead.
ERROR (VersionNotFoundForAPIMethod): API version 'API Version Major: 2, Minor: 37' is not supported on 'list' method.

It is supposed to be still supported, since newton is just 14.


nova (14.0.0.0rc2.dev21)
python-novaclient (6.0.0)

Specification URL (additional information):

https://bugs.launchpad.net/python-openstackclient/+bug/1630161

Comment 2 Artom Lifshitz 2017-01-27 18:22:47 UTC
The fix for openstackclient was released in version 3.8.0. I'm wondering whether we need to backport this to the rhos10 branch, or is it enough that a fixed openstackclient should become available in the rhel-7-server-openstack-11-tools-rpms once rhos11 is released?

Comment 3 Stephen Gordon 2017-02-03 22:23:26 UTC
(In reply to Artom Lifshitz from comment #2)
> The fix for openstackclient was released in version 3.8.0. I'm wondering
> whether we need to backport this to the rhos10 branch, or is it enough that
> a fixed openstackclient should become available in the
> rhel-7-server-openstack-11-tools-rpms once rhos11 is released?

I think we still need the backport unfortunately.

Comment 4 Artom Lifshitz 2017-02-04 00:35:43 UTC
The patch is up [1]. I'll need to figure out who can review it - us Nova engineers don't seem to have +2 ability on python-novaclient.

[1] https://code.engineering.redhat.com/gerrit/#/c/96182/

Comment 5 Julie Pichon 2017-02-07 16:24:51 UTC
Adding link to upstream backport proposal - https://review.openstack.org/#/c/429772/

Comment 6 Julie Pichon 2017-02-08 12:05:11 UTC
Artom, thank you for your work on this!

To clarify the expectations/my understanding: 
- The failing command as specified in the bug description (nova image-list) will still fail, unless used together with the --os-compute-api-version 2.35 switch.
- The patch itself fixes a number of similar, separate issues with the OSC "openstack server" commands (like openstack server list --image <blah>). 

$ openstack server list --image be3fb347-24e7-4956-8566-a36fb9682c2a
API version 'API Version Major: 2, Minor: 37' is not supported on 'list' method.

Comment 7 Artom Lifshitz 2017-02-08 12:47:22 UTC
You've understood correctly. Comment #4 [1] on the original upstream bug hasn't been reproduced here, but it's what we're really fixing.

[1] https://bugs.launchpad.net/nova/+bug/1630161/comments/4

Comment 8 Alan Pevec 2017-02-28 23:56:05 UTC
If this BZ is fixing OSC only, please correct Summary and explain why originally reported issue in novaclient is not going to be fixed.

Comment 9 Artom Lifshitz 2017-03-01 15:43:11 UTC
Alan,

I piggybacked the openstackclient issue on top of an already-reported novaclient issue upstream, then Steve Gordon the whole mess downstream. In retrospect, that wasn't ideal for clarity.

The originally reported issue in novaclient was that 'nova image-list' didn't work. That's invalid because it definitely still works, one just needs to pin the API version to something earlier than 2.36, which is when the image proxy APIs were deprecated.

The issue in openstackclient is sort of related, but not identical. Openstackclient used the nova image API endpoints when doing operations to resources that aren't images, for example booting a server and showing what image it uses in the response. Booting a server should always works, regardless of other deprecations. This bugzilla and the upstream fix are only for the openstackclient issue.

Comment 10 Artom Lifshitz 2017-03-03 20:10:12 UTC
With the fix upstream merged to stable/newton [1], this will be fixed next time the RHOS10 python-openstackclient is rebased from upstream.

[1] https://review.openstack.org/#/c/429772/

Comment 11 Julie Pichon 2018-02-19 17:15:10 UTC
For the record, the upstream patch was pulled into python-openstackclient-3.2.1-3.el7ost for OSP10.