Bug 1399487
Summary: | grub2-install failed in rear recover with /boot partition formatted with XFS | |||
---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Masahiro Matsuya <mmatsuya> | |
Component: | rear | Assignee: | Jakub Mazanek <jmazanek> | |
Status: | CLOSED ERRATA | QA Contact: | Tereza Cerna <tcerna> | |
Severity: | urgent | Docs Contact: | ||
Priority: | urgent | |||
Version: | 7.3 | CC: | amari, gratien.dhaese, imntreal, jmazanek, jmoon, jstodola, khuh, mkolaja, ovasik, pholica, pjones, psklenar, tbskyd, tcerna | |
Target Milestone: | rc | Keywords: | Patch, Regression, ZStream | |
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
Cause: Rear was setting the file system UUID twice
Consequence: Filesystem metadata ended up inconsistent. grub2-install command failed.
Fix: Adjusted rear to set the UUID only once and correctly
Result: The grub2 installation works as expected.
|
Story Points: | --- | |
Clone Of: | ||||
: | 1402716 1404167 (view as bug list) | Environment: | ||
Last Closed: | 2017-08-01 22:19:55 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1402716, 1404167 |
Description
Masahiro Matsuya
2016-11-29 07:24:22 UTC
libxfs/xfs_format.h of xfsprogs package -------------------------------------------- #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0) /* filetype in dirent */ #define XFS_SB_FEAT_INCOMPAT_SPINODES (1 << 1) /* sparse inode chunks */ #define XFS_SB_FEAT_INCOMPAT_META_UUID (1 << 2) /* metadata UUID */ -------------------------------------------- xfs_admin -U command causes to set the XFS_SB_FEAT_INCOMPAT_META_UUID flag. XFS_SB_FEAT_INCOMPAT_FTYPE flag only is regarded as supported by grub2-install. grub-core/fs/xfs.c of grub2 package -------------------------------------------- #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0) /* filetype in dirent */ #define XFS_SB_FEAT_INCOMPAT_SUPPORTED \ (XFS_SB_FEAT_INCOMPAT_FTYPE) -------------------------------------------- In upstream grub2, XFS_SB_FEAT_INCOMPAT_META_UUID is included in XFS_SB_FEAT_INCOMPAT_SUPPORTED. http://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/xfs.c Changing into grub2... This is an easier way to reproduce the problem without rear. 1. install RHEL7.3 with /boot partition fomatted with XFS. 2. Assuming that /boot partition is sda1, the following grub2-probe command should be able to work. (Note: xfs_admin -U command is not executed during installation) # grub2-probe --device /dev/sda1 xfs 3. umount /dev/sda1 4. set an UUID with xfs_admin -U $ uuidgen 78cb73e1-a8b6-4471-a7fc-037ce6191b9e # xfs_admin -U 78cb73e1-a8b6-4471-a7fc-037ce6191b9e /dev/sda1 5. modify UUID= for /boot in /etc/fstab 6. mount /dev/sda1 7. the same grub2-probe command fails as below. # grub2-probe --device /dev/sda1 grub2-probe: error: unknown filesystem. 'grub2-install /dev/sda1' fails as well. # grub2-install /dev/sda1 Installing for i386-pc platform. grub2-install: error: unknown filesystem. Could you check if this is related to https://github.com/rear/rear/pull/1067 ? Sorry for long time no update fix has already been provided as a hotfix. It was tested by customer and functional. I will be closing this bugzilla @gdha Yes, it was related issue That has been fixed by https://github.com/rear/rear/pull/1067/commits/bc09f447b18ede0218677d68dd7eb06c28152b13 and was released with ReaR v2.00 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2052 |