Bug 1399780

Summary:	Use standard refcounting for structures where possible
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	core	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Tracking, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-06 17:37:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2016-11-29 17:38:59 UTC

Description of problem:

Many structures use their own refcounting. libglusterfs provides refcount.h with standard functions. Other structures should use that as well.

Comment 1 Worker Ant 2016-11-29 17:40:29 UTC

REVIEW: http://review.gluster.org/15971 (refcount: return pointer to the structure instead of a counter) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Worker Ant 2016-12-11 08:47:09 UTC

COMMIT: http://review.gluster.org/15971 committed in master by Niels de Vos (ndevos) 
------
commit 2f0e9ab1ef271132b8b7b1af25e23ac7bb0720c8
Author: Niels de Vos <ndevos>
Date:   Tue Nov 29 16:51:58 2016 +0100

    refcount: return pointer to the structure instead of a counter
    
    There are no real users of the counter. It was thought of a handy tool
    to track and debug refcounting, but it is not used at all. Some parts of
    the code would benefit from a pointer getting returned instead.
    
    BUG: 1399780
    Change-Id: I97e52c48420fed61be942ea27ff4849b803eed12
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/15971
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Xavier Hernandez <xhernandez>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Worker Ant 2016-12-12 12:03:10 UTC

REVIEW: http://review.gluster.org/16109 (rpc: use standard refcounting functions for 'struct rpc_clnt') posted (#1) for review on master by Niels de Vos (ndevos)

Comment 4 Worker Ant 2016-12-12 12:41:20 UTC

REVIEW: http://review.gluster.org/16109 (rpc: use standard refcounting functions for 'struct rpc_clnt') posted (#2) for review on master by Niels de Vos (ndevos)

Comment 5 Shyamsundar 2017-03-06 17:37:12 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/