Bug 1400277

Summary: Central Admin Service Provision fails when dialogs have the same label in separate regions
Product: Red Hat CloudForms Management Engine Reporter: Nick Carboni <ncarboni>
Component: ReplicationAssignee: Nick Carboni <ncarboni>
Status: CLOSED CURRENTRELEASE QA Contact: Alex Newman <anewman>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: cpelland, jhardy, obarenbo
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1401014 (view as bug list) Environment:
Last Closed: 2017-06-12 17:41:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1401014    

Description Nick Carboni 2016-11-30 19:11:30 UTC 
Description of problem:
Ordering a service from the classic UI from the global region fails when the dialog associated with the service has the same label as a dialog from a different region.

This causes the dialog's #validate method to return false and fails the service order process with little to no feedback.

Version-Release number of selected component (if applicable):
5.7.0.11

Steps to Reproduce:
1. Configure Central Admin to two separate regions
2. Create a service in each region with the same dialog name
3. Order the service from the global region

Actual results:
The request is not created and there is no error
Comment 2 Nick Carboni 2016-11-30 19:30:39 UTC 
https://github.com/ManageIQ/manageiq/pull/12930
Comment 4 CFME Bot 2016-12-06 17:15:16 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/57810832b252bf007ab71270b87f67cb52bb7a0b

commit 57810832b252bf007ab71270b87f67cb52bb7a0b
Author:     Nick Carboni <ncarboni>
AuthorDate: Wed Nov 30 14:15:33 2016 -0500
Commit:     Nick Carboni <ncarboni>
CommitDate: Wed Nov 30 14:15:33 2016 -0500

    Scope the dialog label uniqueness validation by region
    
    This was failing a service provision from the global region because
    there were dialogs from separate regions in the database with the
    same label.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1400277

 app/models/dialog.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)