Bug 1400375

Summary: deploy heapster only, error is shown when specify env var 'PUBLIC_MASTER_URL'
Product: OpenShift Container Platform Reporter: Peng Li <penli>
Component: HawkularAssignee: Matt Wringe <mwringe>
Status: CLOSED CURRENTRELEASE QA Contact: Peng Li <penli>
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: aos-bugs, xiazhao
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-30 12:48:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Peng Li 2016-12-01 02:33:19 UTC
Description of problem:
try to deploy heapster only, when specify this paramter https://github.com/openshift/origin-metrics/blob/master/metrics-heapster.yaml#L59,  the metrics deployer will show error and stop. looks like this env var is not in use?

Version-Release number of selected component (if applicable):
openshift/origin-metrics-deployer :latest
also seen in OSE metrics 3.4


Steps:

oc project openshift-infra

oc create -f - <<API
apiVersion: v1
kind: ServiceAccount
metadata:
  name: metrics-deployer
secrets:
- name: metrics-deployer
API

oadm policy add-cluster-role-to-user cluster-admin system:serviceaccount:openshift-infra:metrics-deployer
oadm policy add-role-to-user edit system:serviceaccount:openshift-infra:metrics-deployer
oc secrets new metrics-deployer nothing=/dev/null
oadm policy add-cluster-role-to-user cluster-reader system:serviceaccount:openshift-infra:heapster
oadm policy add-role-to-user view system:serviceaccount:openshift-infra:hawkular -n openshift-infra

oc new-app -f metrics-heapster.yaml --as=system:serviceaccount:openshift-infra:metrics-deployer \
> -p IMAGE_PREFIX=openshift/origin- \
> -p IMAGE_VERSION=latest \
> -p PUBLIC_MASTER_URL=$MASTERURL \
> -p MASTER_URL=$MASTERURL \
> -p MODE=deploy 

error: unexpected parameter name "PUBLIC_MASTER_URL"

Actual results:
Error is shown, and deployer stop. remove this, can deploy heapster successfully.

Expected results:
Deploy only heapster successfully.

Additional info:
n/a

Comment 4 Matt Wringe 2016-12-01 19:16:26 UTC
I opened the unused envar in https://github.com/openshift/origin-metrics/pull/271

And I am lowering the priority of this, its really a non-issue aside from some potential confusion over why an envar is there that is not used.

Comment 5 Peng Li 2016-12-02 00:11:36 UTC
PR is merged, set status to verified.

Comment 6 Peng Li 2016-12-02 08:43:34 UTC
User won't see this env var and won't set it correspondingly.