Bug 1400489

Summary: Review Request: perl-BSON - BSON serialization and deserialization
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-BSON-1.2.2-1.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-15 23:29:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1400184    

Description Petr Pisar 2016-12-01 11:23:16 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-BSON/perl-BSON.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-BSON/perl-BSON-1.2.2-1.fc26.src.rpm
Description:
This Perl class implements a BSON encoder and decoder. It consumes
documents (typically hash references) and emits BSON strings and vice
versa in accordance with the BSON specification <http://bsonspec.org/>.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-12-02 14:47:39 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

Binary requires are Ok.
Binary provides are Ok.

$ rpmlint ./perl-BSON*
perl-BSON.noarch: W: spelling-error Summary(en_US) deserialization -> serialization, materialization, denationalization
perl-BSON.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verso
perl-BSON.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-BSON.noarch: W: spelling-error %description -l en_US bsonspec -> conspectus
perl-BSON.src: W: spelling-error Summary(en_US) deserialization -> serialization, materialization, denationalization
perl-BSON.src: W: spelling-error %description -l en_US versa -> avers, verse, verso
perl-BSON.src: W: spelling-error %description -l en_US http -> HTTP
perl-BSON.src: W: spelling-error %description -l en_US bsonspec -> conspectus
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-12-02 15:35:11 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-BSON

Comment 3 Petr Pisar 2016-12-05 07:40:52 UTC
Thank you for the review and the repository.

Comment 4 Petr Pisar 2016-12-05 09:57:14 UTC
Tests fails on i686:

t/legacy/08-string.t ..... ok
    # No tests run!
#   Failed test 'No tests run for subtest "datetime"'
#   at t/legacy/10-bson.t line 434.
During encode_one, Don't know how to encode Math::BigFloat '151109408000' as an Int64. at /builddir/build/BUILD/BSON-v1.2.2/blib/lib/BSON.pm line 299.
 at t/legacy/10-bson.t line 385.
# Looks like your test exited with 255 just after 11.
t/legacy/10-bson.t ....... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 7/17 subtests 

<https://jira.mongodb.org/browse/PERL-694>.

Comment 5 Fedora Update System 2016-12-05 10:24:21 UTC
perl-BSON-1.2.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fac7083e1

Comment 6 Fedora Update System 2016-12-06 03:24:56 UTC
perl-BSON-1.2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fac7083e1

Comment 7 Fedora Update System 2016-12-15 23:29:53 UTC
perl-BSON-1.2.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-12-16 00:25:14 UTC
perl-BSON-1.2.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.