| Summary: | rescan-scsi-bus.sh removes devices after their revision changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Andreas Bleischwitz <ableisch> | ||||
| Component: | sg3_utils | Assignee: | Gris Ge <fge> | ||||
| Status: | CLOSED ERRATA | QA Contact: | zguo <zguo> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 7.3 | CC: | ableisch, coughlan, djez, dkutalek, fge, loberman, ovasik | ||||
| Target Milestone: | rc | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | sg3_utils-1.37-14.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-10-30 10:54:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1420851, 1473612, 1546181 | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Bleischwitz
2016-12-01 11:27:30 UTC
In case that rescan-scsi-bus.sh with option "-r" can not be changed in the behavior, we should at least remark that this could be a very dangerous action as system-devices could be removed and render the system unusable. This should be reflected in the output of "--help" and in the manpage at least. Raised the priority for given reason. Hi Andreas Bleischwitz,
Changing "-r" behaviour is too risky, I am intend to:
1. Add new option like '--ignore-rev-change' to skip remove/readd on disks with
rev change only.
2. Mark '-r' option as 'DANGEROUS'.
How's that sounds to you?
Hi Gris, sounds reasonable. I'm fine with a opt-out for the "-r" parameter and that this will be marked as potentially dangerous. That way we would not change current behaviour - which may be intentionally remove devices on revision-changes. /Andreas Patch send to upstream for review. https://github.com/hreinecke/sg3_utils/pull/13 I didn't mark '-r' as dangerous as 'remove' seems already contain dangerous in it. Hi Andreas Bleischwitz,
I have no idea how to do a live migrate VM.
Could try these rpms in your system for `sudo rescan-scsi-bus.sh -r --ignore-rev`
command:
http://people.redhat.com/fge/BZ_1400491/
Thank you very much.
Not accepted upstream yet. Development Management has reviewed and declined this request. You may appeal this decision by reopening this request. Created attachment 1423018 [details]
scsi_debug code with rev change patch
Reproduce steps:
* Download attached tarball and extract it.
* cd scsi_debug-el7-bz-1400491 && sudo make
* sudo insmod scsi_debug.ko
* To change revision:
echo -n '0001' | sudo tee /sys/module/scsi_debug/parameters/inq_rev
* To check current revision:
sg_inq /dev/sdb
`--ignore-rec` option has been added to `rescan-scsi-bus.sh` command. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3181 |