Bug 1400522

Summary: nova_client module failure
Product: [Fedora] Fedora Reporter: Pavel Raiskup <praiskup>
Component: ansibleAssignee: Kevin Fenzi <kevin>
Status: CLOSED CANTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: a.badger, athmanem, kevin, kupo, mark, maxim, toromoti
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-30 20:21:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Pavel Raiskup 2016-12-01 12:29:59 UTC
To make the deprecated nova_compute module work, ansible should have this
applied:

--- /usr/lib/python2.7/site-packages/ansible/modules/core/cloud/openstack/_nova_compute.py~     2016-12-01 13:26:57.373737517 +0100
+++ /usr/lib/python2.7/site-packages/ansible/modules/core/cloud/openstack/_nova_compute.py      2016-12-01 13:27:05.914809634 +0100
@@ -22,8 +22,8 @@
 import time
 
 try:
-    from novaclient.v1_1 import client as nova_client
-    from novaclient.v1_1 import floating_ips
+    from novaclient.v2 import client as nova_client
+    from novaclient.v2 import floating_ips
     from novaclient import exceptions
     from novaclient import utils
     HAS_NOVACLIENT = True


Otherwise this error occurs:
fatal: [127.0.0.1 -> localhost]: FAILED! => {"changed": false, "failed": true, "msg": "python-novaclient is required for this module"}
        to retry, use: --limit @/home/praiskup/rh/projects/rhcopr/vm-provisioning/alloc.retry

Comment 1 Kevin Fenzi 2016-12-07 03:34:42 UTC
What version of python-novaclient do you have installed? 

I only seem to see v1_1 or v3 here...

Comment 2 Pavel Raiskup 2016-12-07 08:05:04 UTC
Uh.  Whatever version you have, the versioning is weird.  This is on my F25:

$ rpm -q python3-novaclient python2-novaclient
python3-novaclient-3.3.1-3.fc25.noarch
python2-novaclient-3.3.1-3.fc25.noarch

Comment 3 Kevin Fenzi 2016-12-27 22:40:36 UTC
Yeah, this looks like the fix we do want. I have an old python-novaclient here, but all the new ones are v2. 

Do you want to submit a PR upstream for this change? Or would you like me to do so?

Comment 4 Pavel Raiskup 2016-12-29 16:14:27 UTC
Feel free to submit proper PR upstream -- if that's applicable upstream.
But it looks like this is related to Fedora's set of packages only.

Comment 5 Kevin Fenzi 2017-10-30 20:21:26 UTC
Well, this is finally dropped by upstream, so I don't think we can do much here. ;( 

Please feel free to re-open if there's something to be done.