Bug 1400613

Summary: [GANESHA] failed to create directory of hostname of new node in var/lib/nfs/ganesha/ in already existing cluster nodes
Product: [Community] GlusterFS Reporter: Kaleb KEITHLEY <kkeithle>
Component: common-haAssignee: Kaleb KEITHLEY <kkeithle>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: medium    
Version: mainlineCC: bugs, msaini, rhs-bugs, storage-qa-internal
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.10.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1400599
: 1405576 (view as bug list) Environment:
Last Closed: 2017-03-06 17:37:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1400599    
Bug Blocks: 1405576, 1405577    

Comment 1 Worker Ant 2016-12-06 07:03:20 UTC
REVIEW: http://review.gluster.org/16036 (common-ha: add node create new node dirs in shared storage) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2016-12-06 07:26:21 UTC
REVIEW: http://review.gluster.org/16036 (common-ha: add node create new node dirs in shared storage) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2016-12-09 04:12:54 UTC
REVIEW: http://review.gluster.org/16036 (common-ha: add node create new node dirs in shared storage) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 4 Worker Ant 2016-12-09 08:13:05 UTC
REVIEW: http://review.gluster.org/16036 (common-ha: add node create new node dirs in shared storage) posted (#4) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 5 Worker Ant 2016-12-12 16:19:15 UTC
REVIEW: http://review.gluster.org/16036 (common-ha: add node create new node dirs in shared storage) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 6 Worker Ant 2016-12-16 12:24:59 UTC
COMMIT: http://review.gluster.org/16036 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit dc549b330cc1337c60f3c3544986bab13d10d4e5
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Dec 6 02:00:11 2016 -0500

    common-ha: add node create new node dirs in shared storage
    
    When adding a node to the ganesha HA cluster, create the directory
    tree in shared storage for the added node and create sets of symlinks
    to match what is/was created for the other nodes.  I.e. in a four
    node cluster the new node needs a set of links to the four existing
    nodes:
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e1 -> e1
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e2 -> e2
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e3 -> e3
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e4 -> e4
    and all the existing nodes need links added for the new node:
     /run/gluster/shared/nfs-ganesha/$e1/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e2/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e3/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e5/nfs/{ganesha,statd}/$new -> new
    
    Likewise when deleting, remove the dir and symlinks.
    
    Change-Id: Id2f78f70946f29c3503e1e6db141b66cb431e0ea
    BUG: 1400613
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/16036
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: soumya k <skoduri>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>

Comment 7 Worker Ant 2016-12-20 15:51:52 UTC
REVIEW: http://review.gluster.org/16216 (common-ha: add node create new node dirs in shared storage) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 8 Worker Ant 2016-12-21 18:02:59 UTC
REVIEW: http://review.gluster.org/16216 (common-ha: add node create new node dirs in shared storage) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 9 Worker Ant 2016-12-22 14:20:14 UTC
COMMIT: http://review.gluster.org/16216 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit bc74dc62bb97881c9787f1f6ab67e36dfccaea97
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Dec 20 10:48:45 2016 -0500

    common-ha: add node create new node dirs in shared storage
    
    When adding a node to the ganesha HA cluster, create the directory
    tree in shared storage for the added node and create sets of symlinks
    to match what is/was created for the other nodes.  I.e. in a four
    node cluster the new node needs a set of links to the four existing
    nodes:
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e1 -> e1
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e2 -> e2
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e3 -> e3
     /run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e4 -> e4
    and all the existing nodes need links added for the new node:
     /run/gluster/shared/nfs-ganesha/$e1/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e2/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e3/nfs/{ganesha,statd}/$new -> new
     /run/gluster/shared/nfs-ganesha/$e5/nfs/{ganesha,statd}/$new -> new
    
    Likewise when deleting, remove the dir and symlinks.
    
    original change http://review.gluster.org/16036
    
    BUG: 1400613
    Change-Id: I52839046745728d06ab5a07f38081c032093bff6
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/16216
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: soumya k <skoduri>

Comment 10 Shyamsundar 2017-03-06 17:37:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/