Bug 1400845

Summary: JSON output for all Events CLI commands
Product: [Community] GlusterFS Reporter: Aravinda VK <avishwan>
Component: eventsapiAssignee: Aravinda VK <avishwan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.9   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1357753 Environment:
Last Closed: 2017-03-08 10:23:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1357753    
Bug Blocks: 1395603    

Description Aravinda VK 2016-12-02 08:23:18 UTC
+++ This bug was initially created as a clone of Bug #1357753 +++

Description of problem:
To consume the APIs programatically, provide JSON or XML output for gluster-eventsapi commands.

Example, 

gluster-eventsapi start --json
gluster-eventsapi status --json

--- Additional comment from Worker Ant on 2016-11-17 06:10:02 EST ---

REVIEW: http://review.gluster.org/15867 (eventsapi: JSON output and different error codes) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-11-29 06:58:05 EST ---

REVIEW: http://review.gluster.org/15867 (eventsapi: JSON output and different error codes) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-12-02 03:20:42 EST ---

COMMIT: http://review.gluster.org/15867 committed in master by Aravinda VK (avishwan) 
------
commit da71bdcf82a8dc71a1170ad3f190702fa49d2838
Author: Aravinda VK <avishwan>
Date:   Thu Nov 17 15:42:24 2016 +0530

    eventsapi: JSON output and different error codes
    
    JSON outputs are added to all commands, use `--json` to
    get JSON output.
    
    Following error codes are added to differenciate between errors.
    Any other Unknown errors will have return code 1
    
    ERROR_SAME_CONFIG             = 2
    ERROR_ALL_NODES_STATUS_NOT_OK = 3
    ERROR_PARTIAL_SUCCESS         = 4
    ERROR_WEBHOOK_ALREADY_EXISTS  = 5
    ERROR_WEBHOOK_NOT_EXISTS      = 6
    ERROR_INVALID_CONFIG          = 7
    ERROR_WEBHOOK_SYNC_FAILED     = 8
    ERROR_CONFIG_SYNC_FAILED      = 9
    
    Also hidden `node-` commands in the help message.
    
    BUG: 1357753
    Change-Id: I962b5435c8a448b4573059da0eae42f3f93cc97e
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15867
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-12-02 08:24:30 UTC
REVIEW: http://review.gluster.org/16008 (eventsapi: JSON output and different error codes) posted (#1) for review on release-3.9 by Aravinda VK (avishwan)

Comment 2 Worker Ant 2016-12-29 06:27:19 UTC
COMMIT: http://review.gluster.org/16008 committed in release-3.9 by Aravinda VK (avishwan) 
------
commit d8a19cede65f38cf48b9e1724a7f20b01672fe4e
Author: Aravinda VK <avishwan>
Date:   Thu Nov 17 15:42:24 2016 +0530

    eventsapi: JSON output and different error codes
    
    JSON outputs are added to all commands, use `--json` to
    get JSON output.
    
    Following error codes are added to differenciate between errors.
    Any other Unknown errors will have return code 1
    
    ERROR_SAME_CONFIG             = 2
    ERROR_ALL_NODES_STATUS_NOT_OK = 3
    ERROR_PARTIAL_SUCCESS         = 4
    ERROR_WEBHOOK_ALREADY_EXISTS  = 5
    ERROR_WEBHOOK_NOT_EXISTS      = 6
    ERROR_INVALID_CONFIG          = 7
    ERROR_WEBHOOK_SYNC_FAILED     = 8
    ERROR_CONFIG_SYNC_FAILED      = 9
    
    Also hidden `node-` commands in the help message.
    
    > Reviewed-on: http://review.gluster.org/15867
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Prashanth Pai <ppai>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    BUG: 1400845
    Change-Id: I962b5435c8a448b4573059da0eae42f3f93cc97e
    Signed-off-by: Aravinda VK <avishwan>
    (cherry picked from commit da71bdcf82a8dc71a1170ad3f190702fa49d2838)
    Reviewed-on: http://review.gluster.org/16008
    Reviewed-by: Prashanth Pai <ppai>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>

Comment 3 Kaushal 2017-03-08 10:23:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/