Bug 1400926

Summary:	Memory leak when self healing daemon queue is full
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	selfheal	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, mateusz.slupny, ravishankar, sasundar
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1399592	Environment:
Last Closed:	2017-03-08 10:20:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1399592, 1400927
Bug Blocks:

Description Ravishankar N 2016-12-02 10:30:31 UTC

+++ This bug was initially created as a clone of Bug #1399592 +++

Description of problem:

Applications using libgfapi are leaking under high load in when self healing daemon queue is full.

How reproducible:

Setting cluster.heal-wait-queue-length makes the issue easier to reproduce.

--- Additional comment from Worker Ant on 2016-11-29 06:19:26 EST ---

REVIEW: http://review.gluster.org/15968 (selfheal: fix memory leak on full shd queue) posted (#1) for review on master by Anonymous Coward (mateusz.slupny)

--- Additional comment from Worker Ant on 2016-11-30 06:51:18 EST ---

REVIEW: http://review.gluster.org/15968 (selfheal: fix memory leak on full shd queue) posted (#2) for review on master by Mateusz Slupny (mateusz.slupny)

--- Additional comment from Worker Ant on 2016-11-30 23:55:28 EST ---

REVIEW: http://review.gluster.org/15968 (selfheal: fix memory leak on client side healing queue) posted (#3) for review on master by Mateusz Slupny (mateusz.slupny)

--- Additional comment from Worker Ant on 2016-12-01 03:48:25 EST ---

REVIEW: http://review.gluster.org/15968 (selfheal: fix memory leak on full shd queue) posted (#4) for review on master by Mateusz Slupny (mateusz.slupny)

--- Additional comment from Worker Ant on 2016-12-02 03:37:46 EST ---

REVIEW: http://review.gluster.org/15968 (selfheal: fix memory leak on client side healing queue) posted (#5) for review on master by Mateusz Slupny (mateusz.slupny)

--- Additional comment from Worker Ant on 2016-12-02 05:05:52 EST ---

COMMIT: http://review.gluster.org/15968 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit fb95eb4da6f4fc0b9c69e3b159a2214fe47e6d1d
Author: Mateusz Slupny <mateusz.slupny>
Date:   Tue Nov 29 12:01:48 2016 +0100

    selfheal: fix memory leak on client side healing queue
    
    Change-Id: I2beaba829710565a3246f7449a5cd21755cf5f7d
    BUG: 1399592
    Signed-off-by: Mateusz Slupny <mateusz.slupny>
    Reviewed-on: http://review.gluster.org/15968
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Ravishankar N <ravishankar>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-12-02 10:31:46 UTC

REVIEW: http://review.gluster.org/16011 (selfheal: fix memory leak on client side healing queue) posted (#1) for review on release-3.9 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2016-12-05 01:30:08 UTC

COMMIT: http://review.gluster.org/16011 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) 
------
commit be1617531beef54afe506833e03e1653c8b2274d
Author: Mateusz Slupny <mateusz.slupny>
Date:   Tue Nov 29 12:01:48 2016 +0100

    selfheal: fix memory leak on client side healing queue
    
    > Reviewed-on: http://review.gluster.org/15968
    > Tested-by: Pranith Kumar Karampuri <pkarampu>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    > Reviewed-by: Ravishankar N <ravishankar>
    > Smoke: Gluster Build System <jenkins.org>
    (cherry picked from commit fb95eb4da6f4fc0b9c69e3b159a2214fe47e6d1d)
    
    Change-Id: I2beaba829710565a3246f7449a5cd21755cf5f7d
    BUG: 1400926
    Signed-off-by: Mateusz Slupny <mateusz.slupny>
    Reviewed-on: http://review.gluster.org/16011
    Tested-by: Ravishankar N <ravishankar>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2017-03-08 10:20:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/