Bug 1400980

Summary:	s2i 'dotnet run' command should not be used to start the application
Product:	dotNET	Reporter:	Tom Deseyn <tdeseyn>
Component:	rh-dotnetcore10-container	Assignee:	Severin Gehwolf <sgehwolf>
Status:	CLOSED ERRATA	QA Contact:	jiri vanek <jvanek>
Severity:	unspecified	Docs Contact:	Les Williams <lwilliam>
Priority:	unspecified
Version:	1.0	CC:	bgollahe, dbhole, kanderso, lzachar, omajid, sgehwolf, zzambers
Target Milestone:	ga
Target Release:	1.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rh-dotnetcore10-docker-1.0-13	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-20 08:25:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Tom Deseyn 2016-12-02 13:27:06 UTC

An assembly must be built and then run with `dotnet myassembly.dll`.
`dotnet run` introduces a man-in-the-middle process which can lead to strange side-effects.

One important difference is that 'dotnet run' doesn't allow the application to gracefully shut down when receiving SIGINT (https://github.com/dotnet/cli/issues/4856). Fans of 12factor will find this important.

Comment 1 Omair Majid 2016-12-02 19:27:14 UTC

Is there a way to find out what the assembly path/name is so we can use it instead of `dotnet run`?

Comment 2 Severin Gehwolf 2016-12-05 16:55:04 UTC

Perhaps we could move such issues upstream?

https://github.com/redhat-developer/s2i-dotnetcore/issues

Comment 3 Tom Deseyn 2016-12-06 09:42:54 UTC

https://bugzilla.redhat.com/show_bug.cgi?id=1400978 will require to specify the project folder. We can use that to figure out the assembly name.

Comment 4 Tom Deseyn 2016-12-13 12:31:17 UTC

PR: https://github.com/redhat-developer/s2i-dotnetcore/pull/12

Comment 6 zzambers 2017-03-15 18:32:13 UTC

Testsuite passed for both 1.0.4 and 1.1.1

1.0.4
https://bugzilla.redhat.com/show_bug.cgi?id=1430300#c4

1.1.1
https://bugzilla.redhat.com/show_bug.cgi?id=1430310#c4

Comment 8 errata-xmlrpc 2017-03-20 08:25:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0560