Bug 1401080

Summary:	Update shim to allow enrolling of custom signing keys (on Lenovo laptops)
Product:	[Fedora] Fedora	Reporter:	Peter Meier <peter.meier>
Component:	shim-signed	Assignee:	Peter Jones <pjones>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	25	CC:	mjg59, pjones, tomek
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-12 10:57:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Peter Meier 2016-12-02 18:14:30 UTC

Description of problem:

https://github.com/rhinstaller/shim/issues/55

A variety of laptops seem to not be able to enroll a custom key through MOK, as their BIOS don't fully follow the UEFI spec and shim was relaying on certain features of said spec to enroll the key.

The issue above includes patches that make it work also on newer Lenovo systems. Numerous people reported to make it work on various Lenovo systems and I can confirm that using a renewed version of MokManager made it possible to import a certificate on a Lenovo x260.

This is especially severe as any software requiring custom kernel modules (e.g. VirtualBox for use with e.g. Vagrant -> common developer workflow) requires the user of secure boot to be able to sign these modules, so they can be loaded.

Version-Release number of selected component (if applicable): 0.8

How reproducible:

Try to enroll an additional key on a Lenovo laptop. Fails with error "Failed to set variable: (2) Invalid Parameter"

Steps to Reproduce:
1. Generate custom key as described on https://docs.fedoraproject.org/en-US/Fedora/25/html/System_Administrators_Guide/sect-generating-a-public-private-x509-key-pair.html
2. Enroll key as described in https://docs.fedoraproject.org/en-US/Fedora/25/html/System_Administrators_Guide/sect-enrolling-public-key-on-target-system.html
3. Error on reboot

Actual results:

Fails to enroll key

Expected results:

Key is enrolled on any uefi systems supporting secure boot.

So please update shim to a newer version supporting this.

Additional info:

Patches are not part of 0.9 release of shim, but can easily be backported.

Comment 1 Tomasz Kepczynski 2016-12-19 09:22:33 UTC

Also exists on CentOS 7.3 which likely means RHEL 7.3 is also affected.

Comment 2 Fedora End Of Life 2017-11-16 19:28:04 UTC

This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2017-12-12 10:57:50 UTC

Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.