Bug 1401095

Summary:	log the error when locking the brick directory fails
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	posix	Assignee:	Raghavendra Bhat <rabhat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-06 17:37:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Bhat 2016-12-02 19:58:00 UTC

Description of problem:

To prevent the brick process from external unmounts of the export directory, posix locks the it by opening the directory.

If locking the export directory via opendir () fails, then the init of the posix fails and thus the brick is also shut down.

But posix as of now does not log the error it faced while doing opendir ().


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-12-02 19:59:15 UTC

REVIEW: http://review.gluster.org/16018 (storage/posix: log the error when locking the export directory fails) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Worker Ant 2016-12-08 19:18:33 UTC

REVIEW: http://review.gluster.org/16018 (storage/posix: log the error when locking the export directory fails) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 3 Worker Ant 2017-01-03 13:42:45 UTC

COMMIT: http://review.gluster.org/16018 committed in master by Vijay Bellur (vbellur) 
------
commit 369fa575a1089b472c39a3843c56f694e1f7ad6f
Author: Raghavendra Bhat <raghavendra>
Date:   Wed Nov 30 17:44:29 2016 -0500

    storage/posix: log the error when locking the export directory fails
    
    posix xlator tries to prevent external unmount of the brick export directory
    by locking it. It locks the export directory by opening it (i.e. doing a opendir).
    
    But if opendir fails it errors out resulting in the brick process going down. The
    error due to which opendir failed is not logged.
    
    Change-Id: I28648382b7f0b88fb1aeb36152e5ab5d812374c9
    BUG: 1401095
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/16018
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Vijay Bellur <vbellur>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Shyamsundar 2017-03-06 17:37:56 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/