Bug 1401247

Summary:	Tenant cannot import datastore without datastore being locked
Product:	Red Hat CloudForms Management Engine	Reporter:	ldomb
Component:	Automate	Assignee:	mkanoor
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavol Kotvan <pakotvan>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	cpelland, gmccullo, jhardy, kmorey, mkanoor, nstephan, obarenbo, simaishi, tfitzger
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1404669 1404670 (view as bug list)		Environment:
Last Closed:	2017-06-12 17:30:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1404669, 1404670

Description ldomb 2016-12-04 00:05:28 UTC

Description of problem:

A tenant cannot import a datastore without it being locked. Even if the tenant is superadmin of the tenant1. Once the datastore is visible the superadmin tenant of tenant1 one is not able to unlock the domain. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create tenant1 and tenant2. 
2. Create a project under tenant1 or tenant2
3. Create a group and add role superadmin
4. Create a user and add it to the group.
5. Login with the newly created user and upload a domain (not create as create works).
6. The domain is locked and cannot be unlocked by the tenant. 

Actual results:

The domain is locked and cannot be unlocked by the tenant. 

Expected results:
The domain should not be locked for the tenant which uploads the domain. The tenant should be able to unlock the domain. 

Additional info:

Comment 2 ldomb 2016-12-04 00:10:25 UTC

(In reply to ldomb from comment #0)
> Description of problem:
> 
> A tenant cannot import a datastore without it being locked. Even if the
> tenant is superadmin of the tenant1. Once the datastore is visible the
> superadmin tenant of tenant1 one is not able to unlock the domain. 
> 
> Version-Release number of selected component (if applicable):
> 
> 
> How reproducible:
> 
> 
> Steps to Reproduce:
> 1. Create tenant1 and tenant2. 
> 2. Create a project under tenant1 or tenant2
> 3. Create a group and add role superadmin
> 4. Create a user and add it to the group.
> 5. Login with the newly created user and upload a domain (not create as
> create works).
> 6. The domain is locked and cannot be unlocked by the tenant. 
> 
> Actual results:
> 
> The domain is locked and cannot be unlocked by the tenant. 
> 
> Expected results:
> The domain should not be locked for the tenant which uploads the domain. The
> tenant should be able to unlock the domain. 
> 
> Additional info:

Version tested 

5.6.3.3.20161128141841_49d925b

Comment 3 CFME Bot 2016-12-06 22:16:17 UTC

https://github.com/ManageIQ/manageiq/pull/13031

Comment 4 CFME Bot 2016-12-07 14:01:29 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/15127377c058298455b82f03805afa0bc95e9eb5

commit 15127377c058298455b82f03805afa0bc95e9eb5
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Dec 6 15:06:32 2016 -0500
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Tue Dec 6 17:00:18 2016 -0500

    When importing domains from the UI pass in the tenant_id
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401247

 app/services/automate_import_service.rb       | 3 ++-
 spec/services/automate_import_service_spec.rb | 8 ++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)