Bug 1401335
| Summary: | Review Request: python-numpy-stl - Library for reading, writing and modifying STL files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | Package Review | Assignee: | Athos Ribeiro <athoscribeiro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, package-review |
| Target Milestone: | --- | Flags: | athoscribeiro:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-11 07:22:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1401334 | ||
| Bug Blocks: | 1393176 | ||
|
Description
Miro Hrončok
2016-12-04 21:53:10 UTC
Hi Miro, Since the package license is BSD, the license text must be present in the package, according to [1]. Will you check that with upstream and ask them to include it in the package? What is your opinion on having a -doc subpackage for the documentation here, since it is large, considering the package size? [2] Also, do you have any comments on the .so file shipped? I noticed that there are some other python packages that will not run ldconfig whenever they own so files (which are also unversioned) [3] [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation [3] https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries 1) created pull request https://github.com/WoLpH/numpy-stl/pull/42 (will include it in the package once new version happens) 2) I can do that, yes 3) this is OK for Python modules (I cannot find a link to back this up, but simply put the compiled modules are .so files, but not the same as shared libraries mentioned in that link you've provided) Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-numpy-stl.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-numpy-stl-2.0.0-1.fc25.src.rpm Fixed 2). Thanks for the fixes and feedback, Miro. As I said in the first point: BSD license text MUST be shipped in this package according to [1] in comment 1. I did not realize that there was a license file in the github repository though. You should either include the license file from the github repository in the package or ask upstream to release the new version before you push the package. Since you are an experienced packager, I will not block this review here and I will trust you will do the right thing. Package approved. The release happened 2 hours ago! Thanks for the review. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-numpy-stl python-numpy-stl-2.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-df0bca528b python-numpy-stl-2.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-df0bca528b python-numpy-stl-2.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |