| Summary: | Review Request: CuraEngine-lulzbot - Engine for processing 3D models into G-code instructions for 3D printers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-31 06:48:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1393176 | ||
|
Description
Miro Hrončok
2016-12-04 23:57:51 UTC
(There are no Provides and Obsoletes, because CuraEngine will stay in Fedora but will get updated.) At some point, the lulzbot fork will move to the current cura version, but this makes sense for now.
= Review =
- rpmlint returns:
CuraEngine-lulzbot.src: E: description-line-too-long C CuraEngine-lulzbot is a C++ console application for 3D printing G-code generation. It
CuraEngine-lulzbot.src: E: description-line-too-long C application look at cura-lulzbot with is the graphical frontend for CuraEngine-lulzbot.
CuraEngine-lulzbot.src:11: W: macro-in-comment %{name}
CuraEngine-lulzbot.src:11: W: macro-in-comment %{version}
These are all easily fixed, please do it. (There are other rpmlint warnings emitted, but they are all safe to ignore).
- package meets naming guidelines
- package meets packaging guidelines
- license (AGPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Fix the rpmlint issues and I'll approve.
Spec URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot-15.04-5.fc25.src.rpm Fixed description length and macros in comments. Thanks for the feedback. I also plan to build this in F24 and F25 (even though CuraEngine will only change in rawhide) so we can maintain just one spec for cura-lulzbot without ifs. Agreed? Agreed, and approved. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/CuraEngine-lulzbot cura-lulzbot-21.02-2.fc25 CuraEngine-lulzbot-15.04-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-470bdc9696 cura-lulzbot-21.02-2.fc24 CuraEngine-lulzbot-15.04-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-458edd9f9a CuraEngine-lulzbot-15.04-5.fc25, cura-lulzbot-21.02-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-470bdc9696 CuraEngine-lulzbot-15.04-5.fc24, cura-lulzbot-21.02-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-458edd9f9a CuraEngine-lulzbot-15.04-5.fc25, cura-lulzbot-21.02-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. CuraEngine-lulzbot-15.04-5.fc24, cura-lulzbot-21.02-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |