Bug 1401576

Summary: [z-stream clone - 4.0.6] Create a new disk while creating new vm needs to press OK button twice.
Product: Red Hat Enterprise Virtualization Manager Reporter: rhev-integ
Component: ovirt-engineAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED ERRATA QA Contact: meital avital <mavital>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0.5CC: eedri, gklein, gshereme, hifxj, jwoods, lsurette, mavital, mgoldboi, michal.skrivanek, oourfali, rbalakri, Rhev-m-bugs, srevivo, tjelinek, usurse, ykaul
Target Milestone: ovirt-4.0.6Keywords: TestOnly, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1396781 Environment:
Last Closed: 2017-01-30 13:46:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1396781    
Bug Blocks:    

Description rhev-integ 2016-12-05 15:27:57 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1396781 +++
======================================================================

Description of problem:
While creating new VM, select create disk option. After selecting all options and press OK, nothing changes and the configuration is not saved until you press OK again.


Version-Release number of selected component (if applicable):
RHV 4.0.5 admin portal

How reproducible:
Always


Steps to Reproduce:
1. Create New VM.
2. Create disk for this new VM.
3. Press OK to save configuration. 

Actual results:
Nothing happens. 

Expected results:
Configuration should be saved and navigate to create new VM screen. 

Additional info:

(Originally by Ulhas Surse)

Comment 1 rhev-integ 2016-12-05 15:28:02 UTC
I can not simulate this. What I can observe on the other hand is that there is a delay between pressing the OK and the dialog actually saving. Any chance this is a larger delay on your (I guess bigger) environment?

If not, could you please check if there are some error logs in the ui.log after the first pressing of the OK?

(Originally by Tomas Jelinek)

Comment 3 rhev-integ 2016-12-05 15:28:09 UTC
I can not simulate this. What I can observe on the other hand is that there is a delay between pressing the OK and the dialog actually saving. Any chance this is a larger delay on your (I guess bigger) environment?

If not, could you please check if there are some error logs in the ui.log after the first pressing of the OK?

(Originally by Tomas Jelinek)

Comment 4 rhev-integ 2016-12-05 15:28:12 UTC
Hello,

It is not happening for every attempt now. sometime happens and at and other attempt not. I see following logs in ui.log when it fails:


Caused by: com.google.gwt.event.shared.UmbrellaException: Exception caught: (TypeError) 
 __gwt$exception: <skipped>: a is null
	at Unknown.Bv(Unknown Source)
	at Unknown.Jv(Unknown Source)
	at Unknown.L7(Unknown Source)
	at Unknown.O7(Unknown Source)
	at Unknown.Y6(Unknown Source)
	at Unknown.nq(Unknown Source)
	at Unknown.xq(Unknown Source)
	at Unknown.M6(Unknown Source)
	at Unknown.WDm(Unknown Source)
	at Unknown.z5r(Unknown Source)
	at Unknown.aFo(Unknown Source)
	at Unknown.qFo(Unknown Source)
	at Unknown.Ztr(Unknown Source)
	at Unknown.ZZq(Unknown Source)
	at Unknown.Lvl(Unknown Source)
	at Unknown.JJk(Unknown Source)
	at Unknown._2(Unknown Source)
	at Unknown.A2(Unknown Source)
	at Unknown.g7(Unknown Source)
	... 22 more
Caused by: com.google.gwt.core.client.JavaScriptException: (TypeError) 
 __gwt$exception: <skipped>: a is null

(Originally by Ulhas Surse)

Comment 5 rhev-integ 2016-12-05 15:28:16 UTC
I was waiting for more than a minute to respond to create disk but it still is not saving the configuration.

(Originally by Ulhas Surse)

Comment 6 rhev-integ 2016-12-05 15:28:20 UTC
OK, so a null pointer - I would guess it to some race on async calls.

Could you please now provide the logs in an un-obfuscated way? E.g. install the ovirt-engine-webadmin-portal-debuginfo ovirt-engine-userportal-debuginfo, than restart the engine, simulate again and than take the logs.
Also please provide the exact version of the webadmin rpm.

thank you

(Originally by Tomas Jelinek)

Comment 7 rhev-integ 2016-12-05 15:28:24 UTC
Hi Tomas,
I have asked logs from customer environment who has reported the issues and able to reproduce the same in his environment. 

>>> exact version of the webadmin rpm.
~~~
rhevm-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-webadmin-portal-4.0.5.5-0.1.el7ev.noarch
~~~

$ cat installed-rpms | grep debuginfo
ovirt-engine-userportal-debuginfo-4.0.5.5-0.1.el7ev.noarch  Fri Nov 25 08:29:44 2016
ovirt-engine-webadmin-portal-debuginfo-4.0.5.5-0.1.el7ev.noarch Fri Nov 25 08:29:35 2016

(Originally by Ulhas Surse)

Comment 11 rhev-integ 2016-12-05 15:28:38 UTC
The problem is that the event about the fact that the button was clicked is published as an event. Therefore, the order in which the following two events happen are unpredictable:
1: close the disk dialog
2: show VM dialog
3: update values in VM dialog

In most cases it is 1, 2 and than 3, but in some cases it can be 3, 1, 2. This leads to trying to update the properties of a widget which is not visible leading to exceptions.

Coincidentally, there is a different bug (https://bugzilla.redhat.com/show_bug.cgi?id=1391466) which requires not to hide the VM dialog if the disk dialog is shown which will ensure that the VM dialog is always present and regardless of the order of the events, the widgets can be updated. The https://bugzilla.redhat.com/show_bug.cgi?id=1391466 is targeted to 4.0.6 so setting target of this also for 4.0.6 for independent verification.

(Originally by Tomas Jelinek)

Comment 12 rhev-integ 2016-12-05 15:28:42 UTC
Hello, 
Also there is this message appeared while creating disk:

~~~
Uncaught exception occurred. Please try reloading the page. Details: Exception caught: Exception caught: (TypeError) __gwt$exception: <skipped>: a is null
Please have your administrator check the UI logs
~~~

Will this be addressed here or should I create a new bugzilla report. 
The screenshot is already attached with this bugzilla.

(Originally by Ulhas Surse)

Comment 13 rhev-integ 2016-12-05 15:28:45 UTC
addressed here - that is the same issue reported in two different ways.

(Originally by Tomas Jelinek)

Comment 14 rhev-integ 2016-12-05 15:28:49 UTC
Great, thanks for the confirmation.

(Originally by Ulhas Surse)

Comment 17 meital avital 2016-12-12 07:42:32 UTC
Verified on version: 4.0.6.3-0.1.el7ev

Comment 18 Tomas Jelinek 2017-01-05 15:46:23 UTC
*** Bug 1409994 has been marked as a duplicate of this bug. ***

Comment 19 Greg Sheremeta 2017-01-30 13:46:24 UTC
Erratum: https://errata.devel.redhat.com/advisory/25702