Bug 1401597

Summary:	AFR fix locking bug in self-heal code path
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.1.3 (or later)	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-08-29 03:37:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ravishankar N 2016-12-05 16:13:57 UTC

Description of problem:
In self-heal code path, we need to consider bricks as source/sinks only if we got shd domain locks on them. As of today we ignore locked_on[] obtained on shd domain and proceed to select source/sinks solely based on locks obtained on data domain. This can be a problem if replia count>=4 where 2 different shds can do undo pending for the same file.

Comment 1 Worker Ant 2016-12-15 03:13:16 UTC

REVIEW: http://review.gluster.org/16135 (afr: perform data/entry heal under appropriate locks) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Amar Tumballi 2018-08-29 03:37:24 UTC

This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug.