Bug 1401617

Summary: Automate Customization: When editing automate button, it doesn't remember previously saved button image and display field values.
Product: Red Hat CloudForms Management Engine Reporter: Harpreet Kataria <hkataria>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 5.7.0CC: cpelland, hkataria, jhardy, mpovolny, nansari, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:automate:button
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1402139 (view as bug list) Environment:
Last Closed: 2017-06-12 17:37:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1402139    

Description Harpreet Kataria 2016-12-05 17:35:46 UTC
Description of problem: Automate Customization: When editing automate button, it doesn't remember previously saved button image and display field values.


Version-Release number of selected component (if applicable):5.7.z


How reproducible:100%


Steps to Reproduce:
1. Go to Automate Customization Explorer
2. Add a new Custom Button, with Display on Button unchecked and select a button image for the button.
3. Go to Edit the button that was created in step 2, Previously selected Button image and Value of display on Button field are not present.

Actual results: Previously saved values are missing in the form.


Expected results: It should load the values that were saved when button was added or edited.


Additional info:

Comment 3 Harpreet Kataria 2016-12-05 22:33:18 UTC
https://github.com/ManageIQ/manageiq/pull/13001

Comment 4 CFME Bot 2016-12-06 17:16:41 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/e9c0b516c6d36b3efbad13f47c5edfc32ea0758b

commit e9c0b516c6d36b3efbad13f47c5edfc32ea0758b
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Dec 5 17:29:24 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Dec 5 17:29:24 2016 -0500

    Fixed code that sets values of button_image, display & open_url fields
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401617

 app/controllers/application_controller/buttons.rb       | 6 +++---
 spec/controllers/application_controller/buttons_spec.rb | 5 ++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

Comment 6 CFME Bot 2017-01-10 19:11:05 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/914b6b56120e9fb4df42952e597d62211ece6cdc

commit 914b6b56120e9fb4df42952e597d62211ece6cdc
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Dec 5 17:29:24 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jan 10 11:10:14 2017 -0500

    Fixed code that sets values of button_image, display & open_url fields
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401617
    
    (cherry picked from commit e9c0b51)

 app/controllers/application_controller/buttons.rb       | 5 +++--
 spec/controllers/application_controller/buttons_spec.rb | 4 +++-
 2 files changed, 6 insertions(+), 3 deletions(-)

Comment 7 CFME Bot 2017-01-12 02:05:57 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/e9fd798584c0d8960daf6697d5d4ea27caa073c2

commit e9fd798584c0d8960daf6697d5d4ea27caa073c2
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Dec 5 17:29:24 2016 -0500
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Jan 11 16:05:37 2017 +0100

    Fixed code that sets values of button_image, display & open_url fields
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401617
    (transferred from ManageIQ/manageiq@e9c0b516c6d36b3efbad13f47c5edfc32ea0758b)

 app/controllers/application_controller/buttons.rb       | 6 +++---
 spec/controllers/application_controller/buttons_spec.rb | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

Comment 8 Niyaz Akhtar Ansari 2017-03-08 11:17:22 UTC
Verified in Version 5.8.0.4