Bug 1401873

Summary: Incorrect links in REST API for /imagetransfers
Product: [oVirt] ovirt-engine Reporter: Ondra Machacek <omachace>
Component: RestAPIAssignee: Liron Aravot <laravot>
Status: CLOSED NEXTRELEASE QA Contact: Gonza <grafuls>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 4.0.2CC: bugs, eedri, laravot, tnisan, ylavi
Target Milestone: ovirt-4.0.7Keywords: ZStream
Target Release: ---Flags: rule-engine: ovirt-4.0.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1422888 (view as bug list) Environment:
Last Closed: 2017-02-16 13:18:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1422888    

Description Ondra Machacek 2016-12-06 10:24:28 UTC 
curl https://engine/ovirt-engine/api/imagetransfers/

<image_transfers>
  <image_transfer href="/ovirt-engine/api/imagetransfers/71dff49f-f743-4395-927d-0ee7cf243a66" id="71dff49f-f743-4395-927d-0ee7cf243a66">
    ...
    <image href="/ovirt-engine/api/null/8603e3ed-6d90-4a36-93fa-8bfacef22fea" id="8603e3ed-6d90-4a36-93fa-8bfacef22fea"/>
    ...
  </image_transfer>
</image_transfers>

There is "null" in Image link:

  <image href="/ovirt-engine/api/null/8603e3ed-6d90-4a36-93fa-8bfacef22fea" id="8603e3ed-6d90-4a36-93fa-8bfacef22fea"/>

Also, shouldn't this be disk, instead of image??
Comment 1 Liron Aravot 2017-01-05 15:03:26 UTC 
Thanks Ondra,
The cause for the bug here is that we use "image" instead of "disk" in the api- currently when uploading we pass the disk id but as an image which is confusing.

For 4.0 I'm going to remove the link to the image which, on 4.1/4.2 we'll change the api (with backward compatibility) to accept a disk element and we'll have proper link.
Looking forward, when we'll add support to upload to a specific disk snapshot (=image) we'll let the user specify a destination snapshot id within the disk as well (if not specified the 'active' snapshot will be used).

Thanks,
Liron
Comment 2 Liron Aravot 2017-01-05 15:25:10 UTC 
Adding, the term "Image" is currently used in our api for glance images import (contains the details of the glance image) aside from the image transfer usage.
Comment 3 Sandro Bonazzola 2017-01-25 07:57:16 UTC 
4.0.6 has been the last oVirt 4.0 release, please re-target this bug.