Bug 1401894

Summary: fork also forked builds
Product: [Community] Copr Reporter: Pavel Raiskup <praiskup>
Component: frontendAssignee: Dominik Turecek <dturecek>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecified   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-06 07:55:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Pavel Raiskup 2016-12-06 11:10:24 UTC 
I experimented a bit with new fork functionality, and it seems that forked
builds are not forked, there's:
https://pagure.io/copr/copr/blob/b2076f0d963/f/frontend/coprs_frontend/coprs/logic/complex_logic.py#_58

But 'forked' != 'successful' ATM.  I can imagine that there's race ATM, so
simply this patch is not enough:

-            if not successful or build.state == "succeeded":
+            if build.state in ['succeeded', 'forked']:

... but maybe new state 'forking' is needed.  It is not burning issue so I
just filed this bug to not forget.
Comment 1 Pavel Raiskup 2016-12-06 11:12:09 UTC 
Sorry, wrong spelling.  Please substitute 'forked builds are not forked' with
'already successfully forked builds can not be forked _more_'.
Comment 2 Pavel Raiskup 2019-07-26 09:52:21 UTC 
I believe this is fixed now, but we need re-test after the next release.
Comment 3 Pavel Raiskup 2019-10-03 07:41:38 UTC 
It is not yet fixed.  https://pagure.io/copr/copr/issue/1012