Bug 1401990

Summary: openjdk8 on windows updater have inconsistent messages
Product: Red Hat Enterprise Linux 7 Reporter: jiri vanek <jvanek>
Component: java-1.8.0-openjdkAssignee: Alex Kashchenko <akashche>
Status: CLOSED CURRENTRELEASE QA Contact: BaseOS QE - Apps <qe-baseos-apps>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: akashche, jvanek
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Windows   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-14 15:27:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description jiri vanek 2016-12-06 14:23:32 UTC 
When updater.exe sucessfully obtain version.json, it stdout:
"new version file obtained [path] old version [int] new version [int]"

On network error it prints out "http/network error + real_error".
Maybe additional info to this network error is worthy
"http/network error + real_error. But file [path] already exists version [int]"
and
"http/network error + real_error. no old file [path] exists"

On addition IO error during saving should be catched. eg:
"new version obtained [version] but can not be saved [path] real_error"
if  older version already exists, may be mentiond and even with [version]

Where real error may version.json already protected against writeing or dtarget directory can not be writteable at all.

the reason for path everywhere is that path contains NVR which may be hard to guess.


Initial report contained also need for stdoouted trace.json (if created)
But that got already fixed: https://github.com/ojdkbuild/contrib_update-notifier/commit/9635e80168f9e6a13621a347c5d28b3f91f94497

I think heaving similarly detailed error messages for it is overkill, but may be worthy.
Comment 1 Alex Kashchenko 2016-12-06 14:30:28 UTC 
(In reply to jiri vanek from comment #0)
> "http/network error + real_error. But file [path] already exists version
> [int]"
> and
> "http/network error + real_error. no old file [path] exists"
> 
> On addition IO error during saving should be catched. eg:
> "new version obtained [version] but can not be saved [path] real_error"
> if  older version already exists, may be mentiond and even with [version]
> 
> Where real error may version.json already protected against writeing or
> dtarget directory can not be writteable at all.

I can add a "unified" postfix to error messages like this:

[err...]; local version, path: [<expected_or_actual_path>], version_number: [<actual_or_zero>]
Comment 2 jiri vanek 2016-12-06 14:32:38 UTC 
yup, sounds good. TY!
Comment 3 Alex Kashchenko 2016-12-06 14:47:52 UTC 
Added - https://github.com/ojdkbuild/contrib_update-notifier/commit/24e5aa77c6dbc00418a629a390010b9128ccd2c2

Note, version path will be printed only if config was loaded successfully. On config load fail we won't know version path (its parts are in config).
Comment 4 jiri vanek 2016-12-06 15:12:48 UTC 
Thank you. I will test. Can it print -1 if obtaining version fails? Or is 0 considered as error?
Comment 5 Alex Kashchenko 2016-12-06 15:16:21 UTC 
0 means - file wasn't loaded. Cannot do "-1" there easily as version is and unsigned int.
Comment 6 jiri vanek 2016-12-06 16:03:14 UTC 
ook:)
Comment 8 jiri vanek 2016-12-12 08:22:31 UTC 
QA of this tool is depnding on those messages