Bug 1402010

Summary:	Include puppet-fdio in openstack-puppet-modules
Product:	[Community] RDO	Reporter:	Feng Pan <fpan>
Component:	Package Review	Assignee:	hguemar
Status:	CLOSED NEXTRELEASE	QA Contact:	hguemar
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	trunk	CC:	hguemar, jpena
Target Milestone:	---	Flags:	hguemar: rdo-review+
Target Release:	trunk
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-09 11:09:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Feng Pan 2016-12-06 15:03:18 UTC

Description of problem:

puppet-fdio [1] is a puppet module to include FD.io projects VPP and Honeycomb agent, it is required to add TripleO support for VPP.

[1] https://git.fd.io/puppet-fdio

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Javier Peña 2016-12-16 15:37:26 UTC

Initial licensecheck output:

$ licensecheck -r .
./spec/unit/type/vpp_service_spec.rb: *No copyright* UNKNOWN
./spec/unit/provider/vpp_service/vpp_spec.rb: *No copyright* UNKNOWN
./spec/spec_helper_acceptance.rb: *No copyright* UNKNOWN
./spec/spec_helper.rb: *No copyright* UNKNOWN
./spec/shared_examples.rb: *No copyright* UNKNOWN
./spec/classes/honeycomb_spec.rb: *No copyright* UNKNOWN
./spec/classes/fdio_spec.rb: *No copyright* UNKNOWN
./spec/acceptance/honeycomb_spec.rb: *No copyright* UNKNOWN
./spec/acceptance/fdio_spec.rb: *No copyright* UNKNOWN
./setup.py: Apache (v2.0) GENERATED FILE
./scripts/prepare-node.sh: *No copyright* UNKNOWN
./scripts/ci-unit-tests.sh: *No copyright* UNKNOWN
./scripts/ci-beaker.sh: *No copyright* UNKNOWN
./scripts/allow-local-ssh-root.sh: *No copyright* UNKNOWN
./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE
./lib/puppet/type/vpp_service.rb: *No copyright* UNKNOWN
./lib/puppet/provider/vpp_service/vpp.rb: *No copyright* UNKNOWN
./Rakefile: *No copyright* UNKNOWN
./README.md: *No copyright* UNKNOWN
./LICENSE: Apache (v2.0)
./Gemfile: *No copyright* UNKNOWN

The Puppet module is licensed using the Apache 2.0 License.

I see the repo seems to be based on https://github.com/radez/puppet-fdio . The only issue I've found is the copyright assignment from https://git.fd.io/puppet-fdio/tree/LICENSE?id=9326e4237f4d161f297dc4493ab4928ea6e2bf0f#n1 is different to the one in the previous repo, could this be an issue Haïkel?

Comment 2 hguemar 2017-01-25 14:49:21 UTC

Let's assume this is a mistake, but copyright must be fixed to mention original author. So Feng Pan, please fix it upstream asap.
Meanwhile, we can import it.

Comment 3 Feng Pan 2017-01-25 22:35:16 UTC

https://github.com/radez/puppet-fdio is now fixed with the correct files.

Comment 4 Javier Peña 2017-02-09 11:09:47 UTC

The package is already included in the RDO Trunk repos, closing.