Bug 1402022
| Summary: | bodhi mails and subject lines -> strip them to a sane lenght | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Harald Reindl <h.reindl> | ||||||
| Component: | bodhi | Assignee: | Luke Macken <lewk> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 24 | CC: | lewk, randy | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-12-06 18:43:40 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
*** This bug has been marked as a duplicate of bug 1366325 *** well, i was pretty sure that i reported it already but bugzilla didn't show it, most likely because it was closed at solved frankly i don't give a damn if it is solved somewhere in the universe when the issue still exists and the fix is nothing more then a $subject = substr($subject, 0, 255) Hello Harald! Perhaps I misunderstand the meanings of the resolution states, but I intended for Closed --> Upstream to mean that I will track the issue with the upstream issue tracker rather than here on Bugzilla. In this case, that would be the GitHub issue that I marked as the "External Bug ID": https://github.com/fedora-infra/bodhi/issues/882 I generally prefer to use BZ to track packaging related issues for Bodhi (including existing patches from upstream that need to be backported as spec file patches), and I use GitHub to track issues with the code itself. I don't mind at all when people file issues here since bug reporting is a valuable contribution - I usually just refile them at GitHub and mark them Closed --> Upstream and mark the external bug id. I hope that helps, and let me know if you have a suggestion about how I could use Bugzilla to make that clearer in the future. you can track whereever you want but realize that when a reporter goes to buzilla "my bugs" closed ones are not listed and even if it is 1000 times fixed upstream that problem is not the "bodi" package on my machine - it's the damned fedora infrastructure which spams around for many months with such broken mails or multiple "This update has reached the stable karma threshold and can be pushed to stable now if the maintainer wishes" every day for the same package to say it lear: you have not to close a bugrpeort until there is a pedning fix on the *fedora side* and in doubt the reporter is the one who confirms if a problem is resolved Hi Harald, I've actually just today written a patch to stop it from writing the "This update has reached the stable karma threshold and can be pushed to stable now if the maintainer wishes" e-mails repeatedly! https://github.com/fedora-infra/bodhi/pull/1145 We just need to get that reviewed, merged, released, and deployed. There are a few other fixes I need to release as well, so it might take a few more days. thank you! 4 months later the same crap - how many years does it take that someone do a simple change like substr($subject, 250) or so? Return-Path: updates Received: from mail-gw.thelounge.net by mail.thelounge.net (THELOUNGE MTA) with ESMTPS id 3w0h6z56g4zXMv for <h.reindl>; Sat, 8 Apr 2017 18:02:51 +0200 (CEST) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=209.132.181.2; helo=bastion.fedoraproject.org; envelope-from=updates; receiver=h.reindl X-AT-Envelope-From: <updates> X-AT-Envelope-To: <h.reindl> Received: from bastion.fedoraproject.org (bastion01.fedoraproject.org [209.132.181.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail-gw.thelounge.net (THELOUNGE GATEWAY) with ESMTPS id 3w0h6y6RZxz9V8 for <h.reindl>; Sat, 8 Apr 2017 18:02:50 +0200 (CEST) Received: from bodhi04.phx2.fedoraproject.org (bodhi04.phx2.fedoraproject.org [10.5.126.116]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id 56F976049469 for <h.reindl>; Sat, 8 Apr 2017 16:02:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org 56F976049469 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fedoraproject.org; s=bastion; t=1491667368; bh=mR9o+f2TWetyXIuvBYUJj85PD0lCicSY0Z7puBNG4kk=; h=From:To:References:In-Reply-To:Subject:Date:From; b=jCkcD3fcCrE4o6WtZ27eHdyQ2Q378a+2dOfhbayYT6TMnf/UWHKFo80nwSJ8q3e/U KSuyFsBBu76tT83OtpJvG9n339sqRzkHHrqC84tVuj11Jbc8cVbEngV9gno3nQwaZt 6tvM6V3cVBj7xG+s46qjhiEJWLRBhLIaj59xP9XE= From: updates To: h.reindl X-Bodhi-Update-Builds: ksshaskpass-5.9.4-1.fc25,plasma-sdk-5.9.4-1.fc25,polkit-kde-5.9.4-1.fc25,kscr eenlocker-5.9.4-1.fc25,plasma-systemsettings-5.9.4-1.fc25,pam-kwallet-5.9.4-1.fc25,plasma-oxygen-5.9.4-1.fc25,ksysguard-5.9.4-1.fc25,kwin-5.9.4-1.fc25,powerdevil-5.9.4-1.fc25,kf5-kirigami2-2.0.0-2.fc25,bluedevil-5.9.4-1.fc25,plasma-pa-5.9.4-1.fc25,plymouth-theme-breeze-5.9.4-1.fc25,plasma-breeze-5.9.4-1.fc25,plasma-user-manager-5.9.4-1.fc25,plasma-integration-5.9.4-1.fc25,plasma-workspace-5.9.4-1.fc25,plasma-milou-5.9.4-1.fc25,kdecoration-5.9.4-1.fc25,plasma-discover-5.9.4-1.fc25,kactivitymanagerd-5.9.4-1.fc25,libksysguard-5.9.4-1.fc25,kdeplasma-addons-5.9.4-1.fc25,kgamma-5.9.4-1.fc25,plasma-nm-5.9.4-1.fc25,plasma-desktop-5.9.4-1.fc25,breeze-gtk-5.9.4-1.fc25,kmenuedit-5.9.4-1.fc25,kde-gtk-config-5.9.4-1.fc25,kwrited-5.9.4-1.fc25,kwayland-integration-5.9.4-1.fc25,libkscreen-qt5-5.9.4-1.fc25,grub2-breeze-theme-5.9.4-1.fc25,khotkeys-5.9.4-1.fc25,kinfocenter-5.9.4-1.fc25,plasma-workspace-w allpapers-5.9.4-1.fc25,sddm-kcm-5.9.4-1.fc25,kde-cli-tools-5.9.4-1.fc25,kscre en-5.9.4-1.fc25 X-Bodhi-Update-Pushed: True X-Bodhi-Update-Type: enhancement X-Bodhi-Update-Release: F25 References: <bodhi-update-84550-rdieter-F25.org> X-Bodhi-Update-Status: testing In-Reply-To: <bodhi-update-84550-rdieter-F25.org> X-Bodhi-Update-Submitter: rdieter X-Bodhi-Update-Title: bluedevil-5.9.4-1.fc25 breeze-gtk-5.9.4-1.fc25 grub2-breeze-theme-5.9.4-1.fc25 kactivitymanagerd-5.9.4-1.fc25 kde-cli-tools-5.9.4-1.fc25 kde-gtk-config-5.9.4-1.fc25 kdecoration-5.9.4-1.fc25 kdeplasma-addons-5.9.4-1.fc25 kf5-kirigami2-2.0.0-2.fc25 kgamma-5.9.4-1.fc25 khotkeys-5.9.4-1.fc25 kinfocenter-5.9.4-1.fc25 kmenuedit-5.9.4-1.fc25 kscreen-5.9.4-1.fc25 kscreenlocker-5.9.4-1.fc25 ksshaskpass-5.9.4-1.fc25 ksysguard-5.9.4-1.fc25 kwayland-integration-5.9.4-1.fc25 kwin-5.9.4-1.fc25 kwrited-5.9.4-1.fc25 libkscreen-qt5-5.9.4-1.fc25 libksysguard-5.9.4-1.fc25 pam-kwallet-5.9.4-1.fc25 plasma-breeze-5.9.4-1.fc25 plasma-desktop-5.9.4-1.fc25 plasma-discover-5.9.4-1.fc25 plasma-integration-5.9.4-1.fc25 plasma-milou-5.9.4-1.fc25 plasma-nm-5.9.4-1.fc25 plasma-oxygen-5.9.4-1.fc25 plasma-pa-5.9.4-1.fc25 plasma-sdk-5.9.4-1.fc25 plasma-systemsettings-5.9.4-1.fc25 plasma-user-manager-5.9.4-1.fc25 plasma-workspace-5.9.4-1.fc25 plasma-workspace-wallpapers-5.9.4-1.fc25 plymouth-them e-breeze-5.9.4-1.fc25 polkit-kde-5.9.4-1.fc25 powerdevil-5.9.4-1.fc25 sddm-kcm-5.9.4-1.fc25 X-Bodhi: fedoraproject.org Subject: [Fedora Update] [comment] bluedevil-5.9.4-1.fc25 breeze-gtk-5.9.4-1.fc25 grub2-breeze-theme-5.9.4-1.fc25 kactivitymanagerd-5.9.4-1.fc25 kde-cli-tools-5.9.4-1.fc25 kde-gtk-config-5.9.4-1.fc25 kdecoration-5.9.4-1.fc25 kdeplasma-addons-5.9.4-1.fc25 kf5-kirigami2-2.0.0-2.fc25 kgamma-5.9.4-1.fc25 khotkeys-5.9.4-1.fc25 kinfocenter-5.9.4-1.fc25 kmenuedit-5.9.4-1.fc25 kscreen-5.9.4-1.fc25 kscreenlocker-5.9.4-1.fc25 ksshaskpass-5.9.4-1.fc25 ksysguard-5.9.4-1.fc25 kwayland-integration-5.9.4-1.fc25 kwin-5.9.4-1.fc25 kwrited-5.9.4-1.fc25 libkscreen-qt5-5.9.4-1.fc25 libksysguard-5.9.4-1.fc25 pam-kwallet-5.9.4-1.fc25 plasma-breeze-5.9.4-1.fc25 plasma-desktop-5.9.4-1.fc25 plasma-discover-5.9.4-1.fc25 plasma-integration-5.9.4-1.fc25 plasma-milou-5.9.4-1.fc25 plasma-nm-5.9.4-1.fc25 plasma-oxygen-5.9.4-1.fc25 plasma-pa-5.9.4-1.fc25 plasma-sdk-5.9.4-1.fc25 plasma-systemsettings-5.9.4-1.fc25 plasma-user-manager-5.9.4-1.fc25 plasma-workspace-5.9.4-1.fc25 plasma-workspace-wallpapers-5.9.4-1.fc25 plymouth-theme-breeze-5.9.4-1.fc25 polkit-kde-5.9.4-1.fc25 powerdevil-5.9.4-1.fc25 sddm-kcm-5.9.4-1.fc25 Message-Id: <20170408160248.56F976049469.fedoraproject.org> Date: Sat, 8 Apr 2017 16:02:48 +0000 (UTC) X-Spam-Status: No, score=-104.1, tag-level=5.5, block-level=8.0, X-Spam-Report: Flag: No, * -0.5 CUST_DNSWL_11_ORG_H RBL: list.dnswl.org (High Trust) * [209.132.181.2 listed in list.dnswl.org] * -3.5 CUST_DNSWL_13_TL_H RBL: dnswl-aggregate.thelounge.net (High Trust) * [209.132.181.2 listed in dnswl-aggregate.thelounge.net] * -100 USER_IN_WHITELIST From: address is in the user's white-list * -0.1 CUST_DNSWL_2_SENDERSC_L RBL: score.senderscore.com (Low Trust) * [209.132.181.2 listed in score.senderscore.com] * -0.0 SHORTCIRCUIT Not all rules were run, due to a shortcircuited rule * -0.0 CUST_SHORTCIRCUIT1 Skip tests for whitelists and local relays X-Virus-Scanned: Yes The following comment has been added to the bluedevil-5.9.4-1.fc25 breeze-gtk-5.9.4-1.fc25 grub2-breeze-theme-5.9.4-1.fc25 kactivitymanagerd-5.9.4-1.fc25 kde-cli-tools-5.9.4-1.fc25 kde-gtk-config-5.9.4-1.fc25 kdecoration-5.9.4-1.fc25 kdeplasma-addons-5.9.4-1.fc25 kf5-kirigami2-2.0.0-2.fc25 kgamma-5.9.4-1.fc25 khotkeys-5.9.4-1.fc25 kinfocenter-5.9.4-1.fc25 kmenuedit-5.9.4-1.fc25 kscreen-5.9.4-1.fc25 kscreenlocker-5.9.4-1.fc25 ksshaskpass-5.9.4-1.fc25 ksysguard-5.9.4-1.fc25 kwayland-integration-5.9.4-1.fc25 kwin-5.9.4-1.fc25 kwrited-5.9.4-1.fc25 libkscreen-qt5-5.9.4-1.fc25 libksysguard-5.9.4-1.fc25 pam-kwallet-5.9.4-1.fc25 plasma-breeze-5.9.4-1.fc25 plasma-desktop-5.9.4-1.fc25 plasma-discover-5.9.4-1.fc25 plasma-integration-5.9.4-1.fc25 plasma-milou-5.9.4-1.fc25 plasma-nm-5.9.4-1.fc25 plasma-oxygen-5.9.4-1.fc25 plasma-pa-5.9.4-1.fc25 plasma-sdk-5.9.4-1.fc25 plasma-systemsettings-5.9.4-1.fc25 plasma-user-manager-5.9.4-1.fc25 plasma-workspace-5.9.4-1.fc25 plasma-workspace-wallpapers-5.9. 4-1.fc25 plymouth-theme-breeze-5.9.4-1.fc25 polkit-kde-5.9.4-1.fc25 powerdevil-5.9.4-1.fc25 sddm-kcm-5.9.4-1.fc25 update: Created attachment 1270051 [details]
insane
Nobody works full time on Bodhi, and there are quite a few high priority items that take the little bit of time that is spent on Bodhi. Pull requests are welcome! frankly that sort of problems is something i expect to get realized even without user bugreports and fixed "by the way" which is much faster than a user trying to figure out bodhi source including the programing language when i face issues of this kind in our PHP developed software you can be sure that it takes 10 minutes (independent of weekday and time) to add a substr() call , type "svn-commit.sh 'CLEANUP: missing substr(); added'; cms-autodeploy.sh" and distribute that stuff to some hundret customers - and here we are not talking only about *one* instance |
Created attachment 1228582 [details] it's ridiculous besides that it's unreadable in the preview there are mail systems out there which just reject mail swith 2 KB and more subject lines because typically that are spammers trying to put their whole payload in the subject and hope bypass body filters that way