Bug 1402058

Summary:	[RFE] Introspection of diskless nodes
Product:	Red Hat OpenStack	Reporter:	Dmitry Tantsur <dtantsur>
Component:	openstack-ironic-inspector	Assignee:	mkovacik
Status:	CLOSED ERRATA	QA Contact:	mlammon
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	11.0 (Ocata)	CC:	achernet, kbasil, mburns, mlammon, nlevinki, racedoro, sclewis, slinaber
Target Milestone:	Upstream M1	Keywords:	FutureFeature, Triaged
Target Release:	12.0 (Pike)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-ironic-inspector-5.1.1-0.20170418093722.9142b7d.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-13 20:54:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1442136, 1475631

Description Dmitry Tantsur 2016-12-06 16:49:20 UTC

Currently introspection fails when a node has no disks. We need a new API/CLI flag to mark a node as diskless, to allow introspection on it to pass. We probably also need a global option to treat all nodes as diskless.

Then we need Ironic inspection interface to provide this flag based on presence of a valid storage_interface field (to be introduced as part of BFV).

Comment 1 Dmitry Tantsur 2016-12-06 16:50:39 UTC

Upstream RFE: https://bugs.launchpad.net/ironic/+bug/1554243

Comment 3 mkovacik 2017-01-30 17:25:01 UTC

patch merged upstream; https://review.openstack.org/#/c/326620/

Comment 4 mkovacik 2017-02-14 16:08:13 UTC

Update on the upstream status: code merged, present in Ocata (inspector version 5.0)
Changing status to ON_QA;

Comment 10 mlammon 2017-07-20 20:21:17 UTC

This was tested in a kvm virtual environment successfully. 

Steps:
install osp 12 undercloud with several nodes (i.e 3 controller, 2 compute, 1 <spare>)
On hypervisor, virsh detach-disk --domain <spare> --target vda --persistent
openstack baremetal import --json ~/instackenv.json  # contains 
openstack baremetal configure boot
openstack baremetal introspection bulk start
openstack baremetal list  # look for the uuid of <spare> used for 0 disk
openstack baremetal node show <uuid> | grep properties

As expected result:
The introspection succeeded now with one bare metal and property "u'local_gb': u'0'"

Comment 12 mlammon 2017-07-20 20:38:16 UTC

Additional testing to show that we can still detect and fail node with local_gb drive =0 by using device hints

This will set the device hints to seek out this case.

for i in `ironic node-list | awk '/None/ {print $2}'`;
do ironic node-update $i add properties/root_device='{"size": "> 1"}';done

follow with introspection

Comment 15 errata-xmlrpc 2017-12-13 20:54:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462