Bug 1402309

Summary: There should be prompt message when input invalid character in network setting page via cockpit
Product: Red Hat Enterprise Linux 7 Reporter: Huijuan Zhao <huzhao>
Component: cockpitAssignee: Marius Vollmer <mvollmer>
Status: CLOSED CURRENTRELEASE QA Contact: qe-baseos-daemons
Severity: high Docs Contact:
Priority: medium    
Version: 7.3CC: bugs, cshao, dguo, dougsland, jiawu, leiwang, mpitt, qiyuan, rbarry, weiwang, yaniwang, ycui, yzhao
Target Milestone: pre-dev-freezeKeywords: Extras
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-13 10:18:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1400961    
Attachments:
Description Flags
All logs and all files in /etc/sysconfig/network-scripts
none
Screenshot of setting invalid ip
none
Screenshot of invalid ip show none

Description Huijuan Zhao 2016-12-07 08:46:02 UTC
Created attachment 1228933 [details]
All logs and all files in /etc/sysconfig/network-scripts

Description of problem:
There is not prompt message when input invalid character in network setting page via cockpit, it will change to other valid ip randomly, this will cause setting wrong manual ip.
There should be prompt message to prevent setting invalid IP.

Version-Release number of selected component (if applicable):
redhat-virtualization-host-4.0-20161206.0
cockpit-ws-122-3.el7.x86_64
NetworkManager-1.4.0-13.el7_3.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Install RHVH 4.0.6 via anaconda.
2. Reboot RHVH and login cockpit, enter Networking page in cockpit
3. Select one NIC em1, enter configure page, set up IPV4/IPV6 as Manual mode
4. Input invalid IP(such as 300.300.300.300) in IPV4/IPV6 settings page, and click "Apply"

Actual results:
In step4, there is not prompt message, and when input 300.300.300.300, it will change to 45.45.45.45

Expected results:
In step4, there should be prompt message to prevent setting invalid IP. If set invalid IP, should not click "Apply"


Additional info:

Comment 1 Huijuan Zhao 2016-12-07 08:46:52 UTC
Created attachment 1228934 [details]
Screenshot of setting invalid ip

Comment 2 Huijuan Zhao 2016-12-07 08:47:43 UTC
Created attachment 1228935 [details]
Screenshot of invalid ip show

Comment 3 Fabian Deutsch 2016-12-07 13:56:06 UTC
Maybe something that could also be done in NM, and NM provides a CB to eval in Cockpit.

Comment 5 Dominik Perpeet 2016-12-09 09:54:58 UTC
At the very least we should have some input validation. I just tested setting a manual IP address and I can also insert other characters (e.g. ',') which results in the address '0.0.0.0'.
We have to see which parts should be done in NetworkManager and which ones in Cockpit.

Comment 6 Marius Vollmer 2017-01-02 11:30:54 UTC
Fixed via https://github.com/cockpit-project/cockpit/pull/5598

Comment 7 Martin Pitt 2017-10-13 10:18:08 UTC
This was fixed in Cockpit 127. Current RHEL 7.4 has Cockpit 138, so this bug is fixed there. Closing.