Bug 1402319

Taking for review.

One issue with the package Requires for the python3 subpackage from the looks of it.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- python3 subpackage has requires "python3-libvirt-python". The proper package name is libvirt-python3


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -collectd-ceilometer-plugin , python3-collectd-ceilometer-plugin ,
     python-collectd-ceilometer-plugin-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.3.3 starting (python version = 3.5.2)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
Mock Version: 1.3.3
INFO: Mock Version: 1.3.3
Finish: chroot init
INFO: installing package(s): /home/vagrant/1402319-collectd-ceilometer-plugin/results/python3-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm /home/vagrant/1402319-collectd-ceilometer-plugin/results/python2-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm /home/vagrant/1402319-collectd-ceilometer-plugin/results/python-collectd-ceilometer-plugin-doc-1.0.1-1.fc24.noarch.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-24-x86_64/root/ --releasever 24 --disableplugin=local --setopt=deltarpm=false install /home/vagrant/1402319-collectd-ceilometer-plugin/results/python3-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm /home/vagrant/1402319-collectd-ceilometer-plugin/results/python2-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm /home/vagrant/1402319-collectd-ceilometer-plugin/results/python-collectd-ceilometer-plugin-doc-1.0.1-1.fc24.noarch.rpm


Rpmlint
-------
Checking: python2-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm
          python3-collectd-ceilometer-plugin-1.0.1-1.fc24.noarch.rpm
          python-collectd-ceilometer-plugin-doc-1.0.1-1.fc24.noarch.rpm
          collectd-ceilometer-plugin-1.0.1-1.fc24.src.rpm
python-collectd-ceilometer-plugin-doc.noarch: W: summary-not-capitalized C collectd-ceilometer-plugin documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.




Requires
--------
python-collectd-ceilometer-plugin-doc (rpmlib, GLIBC filtered):

python2-collectd-ceilometer-plugin (rpmlib, GLIBC filtered):
    libvirt-python
    python(abi)
    python-babel
    python-pbr
    python-requests

python3-collectd-ceilometer-plugin (rpmlib, GLIBC filtered):
    python(abi)
    python3-babel
    python3-libvirt-python
    python3-pbr
    python3-requests



Provides
--------
python-collectd-ceilometer-plugin-doc:
    python-collectd-ceilometer-plugin-doc

python2-collectd-ceilometer-plugin:
    python-collectd-ceilometer-plugin
    python2-collectd-ceilometer-plugin

python3-collectd-ceilometer-plugin:
    python3-collectd-ceilometer-plugin



Source checksums
----------------
https://files.pythonhosted.org/packages/source/c/collectd-ceilometer-plugin/collectd-ceilometer-plugin-1.0.1.tar.gz :
  CHECKSUM(SHA256) this package     : 3a951504d47ae66f41dc65fcd4afe97b5520395d7d9fbfb93817c359f5d5f501
  CHECKSUM(SHA256) upstream package : 3a951504d47ae66f41dc65fcd4afe97b5520395d7d9fbfb93817c359f5d5f501


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1402319
Buildroot used: fedora-24-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

right, good catch!


Fixed that, updated

SPEC: http://www.matthias-runge.de/fedora/collectd-ceilometer-plugin.spec
SRPM: http://www.matthias-runge.de/fedora/collectd-ceilometer-plugin-1.0.1-2.fc25.src.rpm

You commented out one of the files lines, so now it doesn't build (present but unpackaged files in the python2 site-packages directory).

embarrassing, I' sorry about that.

Could you please try again (same links)

Koji builds fine now:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18025665

Looks good.

You might consider adding runs to the %check section for the python3 as well, but review is good.

*thank you*

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/collectd-ceilometer-plugin