Bug 1402368

Summary:	wrong c++ header file supplied
Product:	[Fedora] Fedora	Reporter:	dzmat
Component:	rb_libtorrent	Assignee:	Fabio Alessandro Locati <fale>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	25	CC:	fale
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-11 10:39:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description dzmat 2016-12-07 11:52:52 UTC

Description of problem: Actually problem is in rb_libtorrent-devel package. 

Version rb_libtorrent-devel-1.1.1-1.fc25.i686.rpm contains wrong header file 
"/usr/include/libtorrent/fingerprint.hpp" This header file contains much lesser string than upstream and miss function generate_fingerprint() and other declarations


Version-Release number of selected component (if applicable):
rb_libtorrent-devel-1.1.1-1.fc25.i686.rpm

How reproducible:
Just compare bundled file in rpm and upstream file https://github.com/arvidn/libtorrent/blob/RC_1_1/include/libtorrent/fingerprint.hpp

Actual results:
header differs from upstream

Expected results:
header should be the same as upstream

Additional info:
fedora24 version 1.0.8 contained normal header, as I have had compiled qbittorent against it without difficulties.

Comment 1 dzmat 2016-12-07 13:51:22 UTC

It looks like new function generate_fingerprint() appeared in rb_libtorrent upstream at 25 Oct 2016 and was used by qbittorrent master branch at 31 Oct 2016. 

So - the only thing I need is just refreshed version of rb_libtorrent*.

Dear maintainers, could you please, issue new version? My qbittorrent tinkering process is disrupted by this inconsistency.

Thank you in advance.

Comment 2 Fabio Alessandro Locati 2016-12-07 14:08:16 UTC

I think upstream screwed up. They changed files in a release that was already released.
You should probably ask them to release a new version (aka: new number) with all the proper files. At that point we can package it.

Cheers,
Fale