Bug 1402446

Summary: Review Request: php-nikic-php-parser3 - A PHP parser written in PHP
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-23 17:14:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
phpcompatinfo-full.log
none
phpcompatinfo-lib.log
none
fedora-review.txt none

Description Remi Collet 2016-12-07 14:56:43 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/7e0ccb7259f589984200a4b7622c9ca411355e7f/php/php-nikic-php-parser3/php-nikic-php-parser3.spec
SRPM URL: http://rpms.remirepo.net/SRPMS/php-nikic-php-parser3-3.0.2-1.remi.src.rpm
Description: 
This is a PHP 5.2 to PHP 7.1 parser written in PHP.
Its purpose is to simplify static code analysis and manipulation.

This package provides the library version 3 and the php-parse command.
The php-nikic-php-parser package provides the library version 2.
The php-PHPParser package provides the library version 1.

Documentation: https://github.com/nikic/PHP-Parser/tree/master/doc

Autoloader: /usr/share/php/PhpParser3/autoload.php

Fedora Account System Username: remi

Comment 1 Remi Collet 2016-12-07 15:03:46 UTC
The main target for this package is PHP 7.1 (so rawhide only)

Will also allow to check how DNF goes with 3 versions of the same library

BTW, php-nikic-php-parser already rebuilt with the command dropped.
http://pkgs.fedoraproject.org/cgit/rpms/php-nikic-php-parser.git/commit/?id=e699940ca831bf694087e4498e8258af34272548

Comment 2 Shawn Iwinski 2016-12-15 03:27:58 UTC
Created attachment 1231946 [details]
phpcompatinfo-full.log

phpCompatInfo version 5.0.1 DB version 1.15.0 built Nov 23 2016 09:41:30 CET

Comment 3 Shawn Iwinski 2016-12-15 03:28:16 UTC
Created attachment 1231947 [details]
phpcompatinfo-lib.log

phpCompatInfo version 5.0.1 DB version 1.15.0 built Nov 23 2016 09:41:30 CET

Comment 4 Shawn Iwinski 2016-12-15 03:29:04 UTC
Created attachment 1231948 [details]
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1402446
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 5 Shawn Iwinski 2016-12-15 03:30:01 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



No blockers.

===== APPROVED =====

Comment 6 Remi Collet 2016-12-15 05:37:17 UTC
Thanks for the review.

New package requested on pkgdb.

Comment 7 Gwyn Ciesla 2016-12-15 13:17:14 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-nikic-php-parser3