Bug 1402487

Summary: "Show detailed events" checkbox of Timelines view removes main events from the timelines
Product: Red Hat CloudForms Management Engine Reporter: Ievgen Zapolskyi <izapolsk>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:timeline:usability
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1411514 (view as bug list) Environment:
Last Closed: 2017-06-12 16:59:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1411514    

Description Ievgen Zapolskyi 2016-12-07 16:18:11 UTC 
Description of problem:
When I check "Show detailed events" checkbox of Timelines, I see only detailed events like "VmStoppingEvent" on timeline but the main events like "VmPoweredOffEvent" disappear.

Functional issue:
If the checkbox had to add detailed events and show them along with main events then this checkbox works incorrectly and filters out main events.

Usability issue:
If the idea of this checkbox was to show only detail events, then 
the checkbox control should be either renamed or replaced with radio group (main events, detailed events) or pulldown menu.


Version-Release number of selected component (if applicable):
5.7.0.14

How reproducible:
100%

Steps to Reproduce:
1. Turn on/off some vm 
2. Open Timelines for that vm
3. Setup Timelines filter to show only Power Activity events and click Apply

4. Check "Show Detailed Events" checkbox and click Apply

Actual results:
Main events like "VmPoweredOff", "VmPoweredOn" showed up after step 3.
Main events from step 3 disappeared after step 4.

Expected results:
If this is functional bug then, this checkbox should cause timeline to display both main and detailed events.
If this is usability bug then, this checkbox has to be either renamed to clearly explain what it does or replaced by correct control like radio group or pulldown menu.
Comment 2 Harpreet Kataria 2016-12-13 17:04:22 UTC 
https://github.com/ManageIQ/manageiq/pull/13149
Comment 3 CFME Bot 2016-12-14 00:01:25 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c4a80f8a4f8691840c264a26be6ec48b778897ce

commit c4a80f8a4f8691840c264a26be6ec48b778897ce
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Dec 13 11:57:26 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Dec 13 11:57:26 2016 -0500

    Show detailed events checkbox should only toggle detailed events.
    
    "Show detailed events" checkbox of Timelines view should not remove critical events from timeline. Critical events should always show on timeline, checkbox should only toggle display of details evenrts on timeline.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1402487

 .../application_controller/timelines/options.rb    |  4 ++-
 .../application_controller/timelines_spec.rb       | 41 +++++++++++++++++-----
 2 files changed, 36 insertions(+), 9 deletions(-)