Bug 1402540

Informal review:

> License:        [MPLv2.0](https://mozilla.org/MPL/2.0/)

Please use License: MPLv2.0
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

> # https://github.com/casperdcl/git-fame/pull/2
> Source1:        LICENSE.txt
> …
> %files
> %license LICENSE.txt

It's not allowed to maintainers to add their own license. You should wait for upstream to properly add a license file. I'm not sure if it's allowed to redistribute MPLv2.0 without a proper license text bundled.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

> Requires:       python3-setuptools

Why need setuptools for runtime?

It is crash on big repo (~4GB).

$ git fame
Blame:   0%|                                                                            | 5/15258 [00:01<1:02:24,  4.07it/s]
Traceback (most recent call last):
  File "/usr/libexec/git-core/git-fame", line 9, in <module>
    load_entry_point('git-fame==1.1.0', 'console_scripts', 'gitfame')()
  File "/usr/lib/python3.5/site-packages/gitfame/_gitfame.py", line 239, in main
    run(args)
  File "/usr/lib/python3.5/site-packages/gitfame/_gitfame.py", line 181, in run
    auths = RE_AUTHS.findall(blame_out)
TypeError: cannot use a string pattern on a bytes-like object

@Rapahel: AFAIK, there is no such requrement

@Vasiliy: The problem is not the repo size, but the presence of UTF characters. I'm working with upstream about that, as for https://github.com/casperdcl/git-fame/issues/3 and https://github.com/casperdcl/git-fame/pull/4. The patch is ready and working.

I'll try to have a new version with both the License inclusion and the bugfix.

Cheers

* Consider taking REAL sources, not the PyPI waste
* /usr/libexec -> %{_libexecdir}
* /usr/bin -> %{_bindir}
* %{python3_sitelib}/gitfame -> %{python3_sitelib}/gitfame/
* %{python3_sitelib}/git_fame-%{version}-py?.?.egg-info -> %{python3_sitelib}/git_fame-*/
* I think Requires: git is missing (or even git-core, depends what it really requires)
* Consider using Cython version, because it's faster (BR: python3-Cython and --cython to the %py3_build/install executions)
* I would also add Recommends: python3-tabulate
* Tests are not ran

Thanks Igor :)

* Consider taking REAL sources, not the PyPI waste
* /usr/libexec -> %{_libexecdir}
* /usr/bin -> %{_bindir}
* %{python3_sitelib}/gitfame -> %{python3_sitelib}/gitfame/
* %{python3_sitelib}/git_fame-%{version}-py?.?.egg-info -> %{python3_sitelib}/git_fame-*/

Should all be done till here

* I think Requires: git is missing (or even git-core, depends what it really requires)

Git is actually not required

* Consider using Cython version, because it's faster (BR: python3-Cython and --cython to the %py3_build/install executions)

Not sure if this would give us real advantages

* I would also add Recommends: python3-tabulate

In v1.2 is now needed, so I've included as required

* Tests are not ran

They need some packages that are not present in Fedora (ie: nose-timer)

SPEC: https://fale.fedorapeople.org/rpms/git-fame.spec
SRPM: https://fale.fedorapeople.org/rpms/git-fame-1.2.0-1.fc25.src.rpm

git is required at least for directory ownership. but it's spawned by subprocess as well.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/git-fame

Please fix (again) while importing:

- Please use License: MPLv2.0

- Remove unneeded Requires: python3-setuptools

- I think also the package has to explicitly 'Require: git' as said to provide
  a proper function.

git-fame-1.2.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fd51877c2

git-fame-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a20a6ee060

git-fame-1.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a20a6ee060

git-fame-1.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fd51877c2

DNF tells me about required dependencies to install the git-fame package:
 git-core
 python-rpm-macros                                             
 python3-devel                                                 
 python3-docopt                                                
 python3-nose                                                  
 python3-py                                                    
 python3-pytest                                                
 python3-rpm-macros                                            
 python3-tabulate                                              
 python3-tqdm                                                  

Why python-rpm-macros, python3-devel, python3-nose, python3-py, python3-pytest and python3-rpm-macros? Normally, those packages are needed to build only but not for runtime.

(In reply to Raphael Groner from comment #13)
> DNF tells me about required dependencies to install the git-fame package:
>  git-core
>  python-rpm-macros                                             
>  python3-devel                                                 
>  python3-docopt                                                
>  python3-nose                                                  
>  python3-py                                                    
>  python3-pytest                                                
>  python3-rpm-macros                                            
>  python3-tabulate                                              
>  python3-tqdm                                                  
> 
> Why python-rpm-macros, python3-devel, python3-nose, python3-py,
> python3-pytest and python3-rpm-macros? Normally, those packages are needed
> to build only but not for runtime.

Looks like some transient deps. Can you file a new bug against git-fame and after debugsolving I will reassign to proper component?

(In reply to Raphael Groner from comment #13)
> DNF tells me about required dependencies to install the git-fame package:
>  git-core
>  python-rpm-macros                                             
>  python3-devel                                                 
>  python3-docopt                                                
>  python3-nose                                                  
>  python3-py                                                    
>  python3-pytest                                                
>  python3-rpm-macros                                            
>  python3-tabulate                                              
>  python3-tqdm                                                  
> 
> Why python-rpm-macros, python3-devel, python3-nose, python3-py,
> python3-pytest and python3-rpm-macros? Normally, those packages are needed
> to build only but not for runtime.

Fixed in https://bugzilla.redhat.com/show_bug.cgi?id=1405639.

git-fame-1.2.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

git-fame-1.2.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.