Bug 1402727

Summary:	Worker restarts on log-rsync-performance config update
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, khiremat
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1393678	Environment:
Last Closed:	2017-03-08 10:23:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1393678, 1402728
Bug Blocks:

Description Aravinda VK 2016-12-08 09:27:11 UTC

+++ This bug was initially created as a clone of Bug #1393678 +++

Description of problem:
If log-rsync-performance config is set using following command, workers restarts and causes reprocessing Changelogs which are processed before the config change.

gluster volume geo-replication <MASTER> <SLAVEHOST>::<SLAVEVOL> config log-rsync-performance true

--- Additional comment from Worker Ant on 2016-11-10 02:12:36 EST ---

REVIEW: http://review.gluster.org/15816 (geo-rep: Do not restart workers when log-rsync-performance config change) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-11-17 01:33:20 EST ---

REVIEW: http://review.gluster.org/15816 (geo-rep: Do not restart workers when log-rsync-performance config change) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-12-02 03:36:56 EST ---

REVIEW: http://review.gluster.org/15816 (geo-rep: Do not restart workers when log-rsync-performance config change) posted (#3) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-12-08 01:05:39 EST ---

COMMIT: http://review.gluster.org/15816 committed in master by Aravinda VK (avishwan) 
------
commit a268e2865c21ec8d2b4fed26715e986cfcc66fad
Author: Aravinda VK <avishwan>
Date:   Thu Nov 10 12:35:30 2016 +0530

    geo-rep: Do not restart workers when log-rsync-performance config change
    
    Geo-rep restarts workers when any of the configurations changed. We
    don't need to restart workers if tunables like log-rsync-performance
    is modified.
    
    With this patch, Geo-rep workers will get new "log-rsync-performance"
    config automatically without restart.
    
    BUG: 1393678
    Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15816
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>

Comment 1 Worker Ant 2016-12-08 09:33:21 UTC

REVIEW: http://review.gluster.org/16070 (geo-rep: Do not restart workers when log-rsync-performance config change) posted (#1) for review on release-3.9 by Aravinda VK (avishwan)

Comment 2 Worker Ant 2017-01-06 07:48:03 UTC

COMMIT: http://review.gluster.org/16070 committed in release-3.9 by Aravinda VK (avishwan) 
------
commit 97e97f10a40358a2bb1f2f50cc1a149f491b18ff
Author: Aravinda VK <avishwan>
Date:   Thu Nov 10 12:35:30 2016 +0530

    geo-rep: Do not restart workers when log-rsync-performance config change
    
    Geo-rep restarts workers when any of the configurations changed. We
    don't need to restart workers if tunables like log-rsync-performance
    is modified.
    
    With this patch, Geo-rep workers will get new "log-rsync-performance"
    config automatically without restart.
    
    > Reviewed-on: http://review.gluster.org/15816
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Kotresh HR <khiremat>
    
    BUG: 1402727
    Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b
    Signed-off-by: Aravinda VK <avishwan>
    (cherry picked from commit a268e2865c21ec8d2b4fed26715e986cfcc66fad)
    Reviewed-on: http://review.gluster.org/16070
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>

Comment 3 Kaushal 2017-03-08 10:23:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/