Bug 1402768

Summary:	When restarting an Embedded Postgre with "rhn-satellite restart" with wrong config in pg_hba.conf, no problem is indicated
Product:	Red Hat Satellite 5	Reporter:	Lukáš Hellebrandt <lhellebr>
Component:	Server	Assignee:	Tomáš Kašpárek <tkasparek>
Status:	CLOSED DEFERRED	QA Contact:	Red Hat Satellite QA List <satqe-list>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	ggainey, lhellebr, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-09 15:11:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Lukáš Hellebrandt 2016-12-08 10:11:36 UTC

Description of problem:
This bug has been created as a reaction to fixing bug 1373900.
When you set wrong configuration in pg_hba.conf and then restart satellite, the problem is not indicated (while "db-config restart" would correctly state it is unable to connect the database). Only the message about database service starting successfully is shown.
Note that later, starting osa-dispatcher fails. That does not, however, say anything about DB start failure.


Steps to Reproduce:
1. PG_HBA=/var/lib/pgsql/data/pg_hba.conf # sat<57
1. PG_HBA=/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_hba.conf # sat>56
2. rhn-satellite status

Actual results:
No problem during DB start mentioned

Expected results:
Some error (preferebly the one db-control prints) shown

Comment 1 Tomas Lestach 2016-12-12 16:43:48 UTC

I am a bit confused here.

Q1:
how do you restart a DB in rhnreg_ks? (based on the summary)

Q2:
summary and description say about satellite restart, but the reproducer steps contain only 'status' (no 'restart'). Also 'Actual results' contains 'DB start'.

Q3:
Is the PG_HBA variable taken into account, when working with PostgreSQL DB?

I may ask more, after these questions are clarified. Thank you.

Comment 2 Lukáš Hellebrandt 2016-12-13 10:36:07 UTC

1) Of course, there should be "rhn-satellite restart", not "rhnreg_ks"

2), 3)
Actually, the reproducer does not make sense as it is, sorry :) ... the correct reproducer is:

1. # PG_HBA=/var/lib/pgsql/data/pg_hba.conf # sat<57
1. # PG_HBA=/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_hba.conf # sat>56
2. # sed -i 's/${rhnschema}/${rhnschema}x/' $PG_HBA # the PG_HBA variable is not used anywhere else
3. # rhn-satellite restart
[...]
Starting rh-postgresql95-postgresql service:               [  OK  ]
[...]
4. # db-control status
The database is offline.

Comment 3 Tomas Lestach 2016-12-13 12:37:04 UTC

Thank you, Lukas! Now, it's clear.

Comment 12 Tomas Lestach 2018-04-09 15:11:35 UTC

We have re-reviewed this bug, as part of an ongoing effort to improve Satellite/Proxy feature and bug updates, review and backlog.

This is a low priority bug and has no currently open customer cases. While this bug may still valid, we do not see it being implemented prior to the EOL of the Satellite 5.x product. As such, this is being CLOSED DEFERRED. 

Closing now to help set customer expectations as early as possible. You are welcome to re-open this bug if needed.