Bug 1402800

Summary: Typo in variable name in /usr/sbin/blkdeactivate: $DEVDIR instead of $DEV_DIR
Product: [Fedora] Fedora Reporter: Vladislav Grigoryev <vg.aetera>
Component: lvm2Assignee: Peter Rajnoha <prajnoha>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: agk, anprice, bmarzins, bmr, bugzilla, gmazyland, heinzm, jonathan, lvm-team, msnitzer, prajnoha, prockai, vg.aetera, zkabelac
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.02.167-1.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-09 22:30:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladislav Grigoryev 2016-12-08 11:34:17 UTC
Description of problem:
Typo in variable name in /usr/sbin/blkdeactivate: $DEVDIR instead of $DEV_DIR

Version-Release number of selected component (if applicable):
device-mapper-1.02.131-5.fc25.x86_64

How reproducible:
On every boot.

Steps to Reproduce:
Reboot.

Actual results:
Creates file "/null" on root filesystem.

Additional info:
# diff -u /usr/sbin/blkdeactivate <(sed 's/$DEVDIR/$DEV_DIR/' /usr/sbin/blkdeactivate)
--- /usr/sbin/blkdeactivate	2016-11-15 12:17:08.000000000 +0300
+++ /dev/fd/63	2016-12-08 14:31:22.448103384 +0300
@@ -466,7 +466,7 @@
 	MPATHD_RUNNING=0
 	test $MPATHD_DO_DISABLEQUEUEING -eq 1 && {
 		if test -f $MPATHD; then
-			if eval $MPATHD show daemon $ERR | grep "running" >$DEVDIR/null; then
+			if eval $MPATHD show daemon $ERR | grep "running" >$DEV_DIR/null; then
 				MPATHD_RUNNING=1
 			fi
 		fi

Comment 1 Peter Rajnoha 2016-12-08 12:12:14 UTC
Already fixed upstream:

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=19e652b182099ca06c678394eccd1988967dacf9

We just forgot to backport the patch.

Comment 2 Fedora Update System 2016-12-08 12:51:35 UTC
lvm2-2.02.167-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bc37b29db5

Comment 3 Fedora Update System 2016-12-08 19:26:46 UTC
lvm2-2.02.167-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-bc37b29db5

Comment 4 Fedora Update System 2016-12-09 22:30:02 UTC
lvm2-2.02.167-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Milan Broz 2016-12-16 18:58:21 UTC
*** Bug 1405568 has been marked as a duplicate of this bug. ***