Bug 1402807
| Summary: | endless-sky-0.9.4-1 is not built with $RPM_OPT_FLAGS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
| Component: | endless-sky | Assignee: | Link Dupont <link> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | besser82, frh+fedora, link, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | endless-sky-0.9.4-3.fc24 endless-sky-0.9.4-3.fc25 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-07 22:18:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 496968 | ||
|
Description
Ville Skyttä
2016-12-08 11:52:03 UTC
New build for rawhide here: http://koji.fedoraproject.org/koji/taskinfo?taskID=16803088 F24 and F25 are building. Scons rebuilds everything again during the install step if CFLAGS is different from what it was during build, so you need to add CCFLAGS="%{optflags}" to the install command as well so it won't rebuild.
I believe LDFLAGS should be set as well with LDFLAGS="%{?__global_ldflags}", but I might be wrong on that.
You're definitely correct. I've set both CXXFLAGS and LDFLAGS in %build and %install. Fixing for rawhide and I'll backport to f25 and f24. endless-sky-0.9.4-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a358e75bb endless-sky-0.9.4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d9fd1363a8 Resetting to ASSIGNED. Scons appends a different optimization level '-O3' to the system-cflags.[1] This is discouraged. [2] ---8<--- Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.VkRmKV + umask 022 + cd /builddir/build/BUILD + cd endless-sky-0.9.4 + CCFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1' + LDFLAGS='-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld' + /usr/bin/scons -j6 PREFIX=/usr DESTDIR=/builddir/build/BUILDROOT/endless-sky-0.9.4-3.fc25.x86_64 scons: Reading SConscript files ... scons: done reading SConscript files. scons: Building targets ... g++ -o build/release/AI.o -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -std=gnu++11 -Wall -O3 source/AI.cpp g++ -o build/release/Account.o -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -std=gnu++11 -Wall -O3 source/Account.cpp ---8<--- Please patch the build-system accordingly. [1] https://kojipkgs.fedoraproject.org//packages/endless-sky/0.9.4/3.fc25/data/logs/x86_64/build.log [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags (In reply to Björn "besser82" Esser from comment #6) > Resetting to ASSIGNED. > > Scons appends a different optimization level '-O3' to the system-cflags.[1] > This is discouraged. [2] Looks like it's set on L26-27 in SConstruct: if env["mode"] != "debug": flags += ["-O3"] endless-sky-0.9.4-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a358e75bb endless-sky-0.9.4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d9fd1363a8 Thanks for pointing that out. I patched out those CCFLAG additions from the SConstruct. Now g++ is invoked with: > g++ -o build/release/AI.o -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -std=gnu++11 source/AI.cpp Building for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17144010 endless-sky-0.9.4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. endless-sky-0.9.4-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |