Bug 1402838

Summary:	Block memory over-commitment when KSM and ballooning are not being used
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Doron Fediuck <dfediuck>
Component:	ovirt-engine	Assignee:	Jenny Tokar <jtokar>
Status:	CLOSED ERRATA	QA Contact:	Shira Maximov <mshira>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.0.5	CC:	jentrena, lsurette, mgoldboi, pdwyer, rbalakri, Rhev-m-bugs, srevivo, trichard, ykaul
Target Milestone:	ovirt-4.1.2	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, the Manager allowed setting memory overcommitment without also enabling KSM or ballooning. The scheduler then used the requested optimization, but there was nothing allowing it at the host level. This has now been fixed so that memory overcommitment can only be set when KSM or ballooning is enabled.	Story Points:	---
Clone Of:
Clones:	1427844 (view as bug list)		Environment:
Last Closed:	2017-05-24 11:22:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427844

Description Doron Fediuck 2016-12-08 12:48:31 UTC

Description of problem:
Currently we allow memory over-commitment even when KSM and ballooning are not being used. Since there's nothing to create over-commitment, we should not allow this.

Version-Release number of selected component (if applicable):
4.0.5 and below.

How reproducible:


Steps to Reproduce:
1. In edit cluster dialog, go to optimization side tab.
2. Set memory optimization to server load (150%)
3. Disable KSM and Ballooning and approve the settings.

Actual results:
Scheduler will use the requested optimization, although there's nothing
to allow this at the host level.

Expected results:
Disable optimization when ksm and ballooning are unavailable.

Additional info:

Comment 1 Doron Fediuck 2016-12-08 12:54:14 UTC

This should consider REST and and GUI, so implementation should be at the engine (CanDoAction during editing and creation).

Comment 7 Shira Maximov 2017-03-20 13:52:01 UTC

can't verify since ovirt 4.1.2 not released yet.

Comment 9 Shira Maximov 2017-03-29 09:03:38 UTC

can't verify since ovirt 4.1.2 not released yet.

Comment 11 Shira Maximov 2017-04-03 13:30:51 UTC

can't verify since ovirt 4.1.2 not released yet.

Comment 14 Shira Maximov 2017-04-26 14:08:14 UTC

verified on : 
The Monitors and USB support 

verification steps:
1. In edit cluster dialog, go to optimization side tab.
2. Set memory optimization to server load (150%)
3. Disable KSM and Ballooning and approve the settings.

Result: 
The Monitors and USB support

Comment 16 errata-xmlrpc 2017-05-24 11:22:00 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1280