Bug 1403026

Summary: Can't Save Automate Methods with Input Parameters
Product: Red Hat CloudForms Management Engine Reporter: mkanoor
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Milan Falešník <mfalesni>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: cpelland, dajohnso, gmccullo, hkataria, jhardy, mfalesni, mpovolny, obarenbo
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1403350 1403351 (view as bug list) Environment:
Last Closed: 2017-06-12 16:35:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1403350, 1403351    
Attachments:
Description Flags
Screen shot of the error none

Description mkanoor 2016-12-08 22:42:43 UTC
Created attachment 1229671 [details]
Screen shot of the error

Description of problem:
If an Automate Method has Input Parameters, we get a save error,
"Error during Add name can't be blank"

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a new Automate Method
2. Add Inout Parameters
3.

Actual results:
Error during Add name can't be blank

Expected results:
Should be able to save the method

Additional info:

Comment 2 mkanoor 2016-12-09 15:18:43 UTC
This is broken in Darga, Euwe and master. Does QE have test cases around this feature.

Comment 3 Harpreet Kataria 2016-12-09 15:55:46 UTC
https://github.com/ManageIQ/manageiq/pull/13087

Comment 4 Dave Johnson 2016-12-09 18:35:11 UTC
Milan, please review this and answer Madhu's question in comment 2 around test case coverage.  We should have another review with him and the team around automate coverage in general.

Comment 5 CFME Bot 2016-12-09 18:45:56 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/cd6a6724d0af8cf85dfb700c5d27344ef7d3a904

commit cd6a6724d0af8cf85dfb700c5d27344ef7d3a904
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 9 10:53:54 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Dec 9 10:53:54 2016 -0500

    Fixed code to expect keys as strings instead of symbols.
    
    This issue was introduced in https://github.com/ManageIQ/manageiq/pull/12322, some of the code is common between class schema editor and method editor that caused method editor to break.
    Fixed any affected spec tests.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1403026

 app/controllers/miq_ae_class_controller.rb       |  8 ++-
 spec/controllers/miq_ae_class_controller_spec.rb | 68 ++++++++++++------------
 2 files changed, 37 insertions(+), 39 deletions(-)

Comment 9 Milan Falešník 2017-02-28 13:45:51 UTC
Verified on 5.8.0.2, it is possible to create a method with inputs.