Bug 1403358
Summary: | Add Provider->Type "RHEVM" should change to "RHV" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> | ||||||
Component: | Providers | Assignee: | Boriso <bodnopoz> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Ilanit Stein <istein> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | 5.7.0 | CC: | bodnopoz, cpelland, istein, jfrey, jhardy, masayag, mgoldboi, obarenbo, oourfali, simaishi | ||||||
Target Milestone: | GA | Keywords: | ZStream | ||||||
Target Release: | 5.7.3 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | rhev | ||||||||
Fixed In Version: | 5.7.3.1 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | 1372992 | Environment: | |||||||
Last Closed: | 2017-06-28 14:57:56 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | RHEVM | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 1372992 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Comment 2
CFME Bot
2017-01-09 18:20:48 UTC
Provider type was changed from "RHEVM" to "RHVM". It should have been changed to "RHV". Therefore, moving bug back to assigned. (In reply to Ilanit Stein from comment #3) > Provider type was changed from "RHEVM" to "RHVM". > It should have been changed to "RHV". > Therefore, moving bug back to assigned. Why? RHVM makes more sense to me. The bug request was to change it to "RHV", but it was changed to "RHVM" I advised with Moran G. on this, and he answered that is should be "RHV": "it should be consistent with the other product names in CF" Sure. Targeting to 5.7.2. So just to make sure - instead of "Red Hat Virtualization Manager" it should just say "Red Hat Virtualization"? exactly. Created attachment 1247039 [details]
provider_discovery_dialog.png
Created attachment 1247040 [details]
provider_added_name.png
I noticed that the name "RHEVM" appear on CFME in more places, that need to be updated as well. for example, Provider discovery menu (see attached "provider_discovery_dialog.png ") or after discover is done, the RHV provider is added with a default name, that contain RHEVM (see attached "provider_added_name.png"). There might be some more places, where the "RHEVM" string is used, and it is worth looking for those on CFME code. Do we want to address renaming of all occurrences within this bug, or should I open a separate bug please? New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/cc6435ce130d29908cac69c694e563e3158bb069 commit cc6435ce130d29908cac69c694e563e3158bb069 Author: Brandon Dunne <brandondunne> AuthorDate: Mon Apr 10 14:56:22 2017 -0400 Commit: Satoe Imaishi <simaishi> CommitDate: Mon Apr 17 16:09:03 2017 -0400 Merge pull request #14703 from borod108/bug/rhvm_to_rhv Change RHVM to RHV (cherry picked from commit 7fe01a5e75c989318abcc4375cf87c8d8bc52182) https://bugzilla.redhat.com/show_bug.cgi?id=1403358 spec/models/ext_management_system_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/54e2a77efa08577d430817627a2030045680a432 commit 54e2a77efa08577d430817627a2030045680a432 Author: Marcel Hild <hild> AuthorDate: Mon Apr 10 19:27:03 2017 +0200 Commit: Satoe Imaishi <simaishi> CommitDate: Mon Apr 17 16:10:55 2017 -0400 Merge pull request #6 from borod108/bug/rhvm_to_rhv Change RHVM to RHV (cherry picked from commit 1f0a82d599bc1405e53c4ba01a6d3b6a62b2d8bc) https://bugzilla.redhat.com/show_bug.cgi?id=1403358 app/models/manageiq/providers/redhat/infra_manager.rb | 2 +- spec/models/manageiq/providers/redhat/infra_manager_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/aca3a3a39808bd6e420e0486a87416e0f2d84546 commit aca3a3a39808bd6e420e0486a87416e0f2d84546 Author: Martin Povolny <mpovolny> AuthorDate: Mon Apr 10 09:09:17 2017 +0200 Commit: Satoe Imaishi <simaishi> CommitDate: Mon Apr 17 16:13:10 2017 -0400 Merge pull request #973 from borod108/bug/rhvm_to_rhv Change RHVM to RHV (cherry picked from commit 8c4b20e96df202a83cafd0b87e8a75af14e924a4) https://bugzilla.redhat.com/show_bug.cgi?id=1403358 app/helpers/application_helper/discover.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Verified on CFME-5.7.3.1 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:1601 |