Bug 1403385

Summary: [DOCS] Custom buildConfig strategy "from" field is not documented
Product: OKD Reporter: Timothy Williams <tiwillia>
Component: DocumentationAssignee: brice <bfallonf>
Status: CLOSED CURRENTRELEASE QA Contact: Wang Haoran <haowang>
Severity: medium Docs Contact: Vikram Goyal <vigoyal>
Priority: medium    
Version: 3.xCC: aos-bugs, mmccomas, tiwillia
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-09 01:25:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Timothy Williams 2016-12-09 22:16:43 UTC 
Document URL: 
  https://docs.openshift.org/latest/dev_guide/builds.html#custom-strategy-options

Section Number and Name: 
  Custom Strategy Options

Describe the issue: 
  When specifying a custom strategy for a buildConfig, it is necessary to include a 'From' tag in the strategy definition, specifying the docker image to use for the custom build.

Suggestions for improvement: 
  Similar to how there is a section on "secrets" for the customStrategy, there should be a section defining the "from" field that provides a helpful example.

Additional information: 
  The link below shows an example of a valid custom strategy buildConfig that can be used as a good reference:

  https://docs.openshift.org/latest/creating_images/s2i_testing.html#using-openshift-build-for-automated-testing
Comment 1 Vikram Goyal 2016-12-16 00:11:44 UTC 
@Brice: This is tagged with Origin - but see if it applies to Enterprise as well before proceeding: https://docs.openshift.com/container-platform/3.3/dev_guide/builds.html#custom-strategy-options
Comment 2 brice 2016-12-19 04:22:48 UTC 
Submitted a PR for this BZ:

https://github.com/openshift/openshift-docs/pull/3411

Tim, can I get an ack this fulfills this BZ? Thanks!
Comment 3 Timothy Williams 2016-12-19 16:07:53 UTC 
Looks great, thanks!
Comment 4 openshift-github-bot 2016-12-20 23:17:08 UTC 
Commit pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/343e505e1f60e98a386491a6bb1323690b730f54
Merge pull request #3411 from bfallonf/from_1403385

Bug 1403385 added from section to custom builds
Comment 5 brice 2017-02-09 01:25:14 UTC 
Link to released docs:

https://access.redhat.com/documentation/en/openshift-container-platform/3.4/single/developer-guide/#docker-strategy-from