| Summary: | [RFE] Should accept any bond name starting with bond | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Huijuan Zhao <huzhao> |
| Component: | BLL.Network | Assignee: | Ales Musil <amusil> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Michael Burman <mburman> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | --- | CC: | amusil, bugs, cshao, danken, dougsland, fdeutsch, huzhao, leiwang, lsurette, mburman, qiyuan, rbarry, srevivo, weiwang, yaniwang, ycui |
| Target Milestone: | ovirt-4.3.0 | Keywords: | FutureFeature |
| Target Release: | 4.3.0 | Flags: | rule-engine:
ovirt-4.3+
mburman: testing_plan_complete+ ylavi: planning_ack+ danken: devel_ack+ mburman: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-4.3.0_alpha | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-13 07:44:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1624069 | ||
| Bug Blocks: | |||
| Attachments: | |||
Created attachment 1230705 [details]
Screenshot of invalid bond name
Created attachment 1230706 [details]
Screenshot of networking after failed adding rhvh to rhvm
Moving this back to RHEV, because it seems to be a limitation of vdsm. Both Engine and Vdsm support only bond+number bondnames. But when and how does adding a node fail? What is the error exposed to the user? Can you attach engine.log? (I could not find it in the big sosreport dump) (In reply to Dan Kenigsberg from comment #4) > Both Engine and Vdsm support only bond+number bondnames. But when and how > does adding a node fail? What is the error exposed to the user? Can you > attach engine.log? (I could not find it in the big sosreport dump) After setup bond with name bd0 on node, when adding the node to engine with bd0, it failed when configure management network on node. Please refer to attachment for detailed error and engine.log. Created attachment 1233768 [details] Comment 5: error exposed to user Created attachment 1233769 [details] Comment 5: engine.log in engine side (In reply to Huijuan Zhao from comment #5) > After setup bond with name bd0 on node, when adding the node to engine with > bd0, it failed when configure management network on node. Please refer to > attachment for detailed error and engine.log. Additional info: vdsmd status on node after failed adding node to engine: # systemctl status vdsmd ● vdsmd.service - Virtual Desktop Server Manager Loaded: loaded (/usr/lib/systemd/system/vdsmd.service; enabled; vendor preset: enabled) Active: active (running) since Tue 2016-12-20 09:28:09 GMT; 6min ago Main PID: 24151 (vdsm) CGroup: /system.slice/vdsmd.service └─24151 /usr/bin/python /usr/share/vdsm/vdsm Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 ask_user_info() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 client step 1 Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 ask_user_info() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 make_client_response() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 client step 2 Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 parse_server_challenge() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 ask_user_info() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 make_client_response() Dec 20 09:28:10 ibm-x3650m5-04.lab.eng.pek2.redhat.com python[24151]: DIGEST-MD5 client step 3 Dec 20 09:28:14 ibm-x3650m5-04.lab.eng.pek2.redhat.com vdsm[24151]: vdsm vds ERROR u'bd0' is not a valid bonding device name Traceback (most recent call last): File "/usr/share/vdsm/API.py", line 1473, in setupNetworks... Hint: Some lines were ellipsized, use -l to show in full. I am not sure we must support just ANY bond name; but we should allow more significant names with the `bond` prefix. I'd like to support only names such as "bond20g" (bond*) Note that this RFE shouldn't be backported to 4.2.z, only for 4.3 Ales, could you please add example or explanation to what kind of custom bond names are acceptable and which not? Thanks, The format is: "bond" followed by any printable ASCII character (a-z A-Z 0-9 _). Length is 15 characters max. (In reply to Ales Musil from comment #13) > The format is: "bond" followed by any printable ASCII character (a-z A-Z 0-9 > _). > Length is 15 characters max. Oh ok, what will happen if my custom bond name has 13 characters and i'm attaching a vlan tagged network to it with tag 166? what will be with the max 15 characters? Good point thanks for bringing it up. It actually blows vdsm so we need to limit it to 10 characters or do another approach. Is it any different with currently-supported bond12345678901 ? Verified on - 4.3.0-0.6.alpha2.el7 This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1230704 [details] All logs and all files in /etc/sysconfig/network-scripts Description of problem: There is not prompt message when input invalid bond name in network setting page via cockpit, and can take effect after set up invalid bond name. In fact, we only support the bond name as bond[0-99], if we setup invalid bond name such as bd0, this will cause adding rhvh to rhvm failed. There should be prompt message to prevent setting invalid bond name via cockpit. Version-Release number of selected component (if applicable): redhat-virtualization-host-4.0-20161206.0 cockpit-ws-122-3.el7.x86_64 NetworkManager-1.4.0-13.el7_3.x86_64 How reproducible: 100% Steps to Reproduce: 1. Install RHVH 4.0.6 via anaconda. 2. Reboot RHVH and login cockpit, enter Networking page in cockpit 3. Create bond which named bd0 over one NIC em1 4. Add rhvh to rhvm with bond bd0 Actual results: In step3, there is not prompt message, can set bd0 successful In step4, add rhvh to rhvm failed Expected results: In step3, There should be prompt message to prevent setting invalid bond name via cockpit, and should set up bond failed with invalid bond name. Additional info: