Bug 1403973

Summary: /usr/bin/more crash on repeat search on failed regex match
Product: Red Hat Enterprise Linux 7 Reporter: Paulo Andrade <pandrade>
Component: util-linuxAssignee: Karel Zak <kzak>
Status: CLOSED ERRATA QA Contact: Radka Brychtova <rskvaril>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.2CC: bblaskov, pandrade
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: util-linux-2.23.2-36.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 21:41:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Paulo Andrade 2016-12-12 19:05:16 UTC
While trying to figure a reproducer to rhbz#1403971
I managed to get /usr/bin/more to crash on another
condition. For example:

(gdb) bt
 #0  __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
#1  0x00007ffff78c8d0f in __regcomp (preg=preg@entry=0x7fffffffde30, pattern=0x0, cflags=cflags@entry=8)
    at regcomp.c:499
#2  0x0000000000405813 in search (buf=<optimized out>, file=file@entry=0x60ee00, n=n@entry=1)
    at text-utils/more.c:1591
#3  0x0000000000405d6a in command (filename=filename@entry=0x0, f=f@entry=0x60ee00) at text-utils/more.c:1344
#4  0x0000000000406664 in screen (f=f@entry=0x60ee00, num_lines=<optimized out>, num_lines@entry=32)
    at text-utils/more.c:708
#5  0x0000000000402365 in main (argc=<optimized out>, argv=<optimized out>) at text-utils/more.c:503

  Sample steps to reproduce:

$ /usr/bin/more /etc/ld.so.cache

Press //.a to search for a pattern.

Press <Enter>

Press . to repeat least search.

It crashes.

Comment 2 Karel Zak 2016-12-14 10:52:48 UTC
It seems I need your /etc/ld.so.cache :-)  ...I'm not able to reproduce this problem (as well as bug #1403971).

Can you try it with more(1) from Fedora?

The problem with "repeat search crash" should be already fixed on Fedora by upstream commit
https://github.com/karelzak/util-linux/commit/bc1ed338814f69473629b04c5e9efae5d7db3b72

Comment 3 Paulo Andrade 2016-12-14 11:38:27 UTC
  It just needs a file that does not match. I used
/etc/ld.so.cache as an example, based on user example
on rhbz#1403971 :)

  I confirm it is corrected in Fedora 25.

Comment 8 errata-xmlrpc 2017-08-01 21:41:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2186