Bug 1404012
| Summary: | Review Request: module-build-service - The Module Build Service for Modularity | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Michael DePaulo <mikedep333> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mikedep333, msuchy, package-review, panemade, rbean, TicoTimo |
| Target Milestone: | --- | Flags: | mikedep333:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-11 18:22:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralph Bean
2016-12-12 20:47:07 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16857938 Preliminary review: * you are missing systemd snippets https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd * it is shame that you start with python2 when everything is being moved to python3 :( (but it does not block the review) * there are test in tar.gz, but not used in %check. Any reason for that? * it would be nice to have man pages for /usr/bin/* tools (In reply to Miroslav Suchý from comment #2) > Preliminary review: > * you are missing systemd snippets > https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd Thanks! We can add these. > * it is shame that you start with python2 when everything is being moved to > python3 :( (but it does not block the review) Agreed. :( We started off on python3, but got blocked by the `koji` libs still being python2 only. As I understand it, there is movement on making them python3-capable upstream, so we should be able to port over sooner than later. > * there are test in tar.gz, but not used in %check. Any reason for that? Yes, I believe that some of them require network connectivity which would fail in koji. I can have a closer look and give a more thorough assessment. > * it would be nice to have man pages for /usr/bin/* tools Yes, agreed. We should add `--help` options to each of those commands and then use help2man. OK, two of four taken care of: - The test suite now runs in the check section (yay!) - systemd scriptlets are now in place. Nothing I can do about py3 for the moment. I filed an issue upstream here to track adding `--help` information and man pages to various commands. We'll include them in a future release: https://pagure.io/fm-orchestrator/issue/266 New release of the specfile and srpm up for review here: Spec URL: http://threebean.org/rpm/SPECS/module-build-service.spec SRPM URL: http://threebean.org/rpm/SRPMS/module-build-service-1.0.2-1.fc25.src.rpm My review of 1.0.2-1: Overall: NEEDSWORK Only 1 Potential Issue: module-build-service.noarch: W: python-bytecode-without-source /usr/lib/python2.7/site-packages/module_build_service/scheduler/consumer.pyc (Note that this is my 1st package review. I apologize in advance for any mistakes.) Thanks Michael! Here is a revision that removes that file that should've been absent. Spec URL: http://threebean.org/rpm/SPECS/module-build-service.spec SRPM URL: http://threebean.org/rpm/SRPMS/module-build-service-1.0.2-2.fc25.src.rpm ACCEPTED now Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/module-build-service |