Bug 1404101

Summary:	Snapshot: Snapshot create command fails when gluster-shared-storage volume is stopped
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	ashah, bugs, rhs-bugs, rjoseph, storage-qa-internal
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1402828	Environment:
Last Closed:	2017-03-08 10:23:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1402774, 1402828
Bug Blocks:

Description Avra Sengupta 2016-12-13 04:51:02 UTC

+++ This bug was initially created as a clone of Bug #1402828 +++

+++ This bug was initially created as a clone of Bug #1402774 +++

Description of problem:

When cluster.enable-shared-storage is enable , however if gluster-shared-storage is stopped, Create snapshot command fails.

Version-Release number of selected component (if applicable):

[root@rhs-client46 ~]# rpm -qa | grep glusterfs
glusterfs-debuginfo-3.8.4-6.el7rhgs.x86_64
glusterfs-fuse-3.8.4-7.el7rhgs.x86_64
glusterfs-geo-replication-3.8.4-7.el7rhgs.x86_64
glusterfs-libs-3.8.4-7.el7rhgs.x86_64
glusterfs-client-xlators-3.8.4-7.el7rhgs.x86_64
glusterfs-api-3.8.4-7.el7rhgs.x86_64
glusterfs-server-3.8.4-7.el7rhgs.x86_64
glusterfs-3.8.4-7.el7rhgs.x86_64
glusterfs-cli-3.8.4-7.el7rhgs.x86_64
samba-vfs-glusterfs-4.4.6-2.el7rhgs.x86_64



How reproducible:

100%

Steps to Reproduce:
1. Create 2*2 distribute volume
2. enabled cluster.enable-shared-storage
3. stop gluster-shared-storage
4. Create snapshot 

Actual results:

Create snapshot  command fails

Expected results:

Create snapshot command should not fail

Additional info:

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-12-08 05:21:37 EST ---

This bug is automatically being proposed for the current release of Red Hat Gluster Storage 3 under active development, by setting the release flag 'rhgs‑3.2.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Worker Ant on 2016-12-09 05:56:55 EST ---

REVIEW: http://review.gluster.org/16094 (snapshot/ganesha: Copy export.conf, only if nfs.ganesha is enabled.) posted (#1) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Worker Ant on 2016-12-12 01:22:25 EST ---

REVIEW: http://review.gluster.org/16094 (snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.) posted (#2) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Worker Ant on 2016-12-12 06:59:47 EST ---

COMMIT: http://review.gluster.org/16094 committed in master by Rajesh Joseph (rjoseph) 
------
commit 74322ce58b1c949e11cb0aa72bfded0e34422157
Author: Avra Sengupta <asengupt>
Date:   Fri Dec 9 15:01:40 2016 +0530

    snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.
    
    Status of the volume being exported via nfs ganesha, should be
    checked by checking if ganesha.enable is set or not, rather than
    deciding based on the errno of the stat
    
    Change-Id: Iaff786d9f77a2de1322ce8ccb4b80954f84d3373
    BUG: 1402828
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/16094
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 1 Worker Ant 2016-12-13 04:52:46 UTC

REVIEW: http://review.gluster.org/16112 (snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.) posted (#1) for review on release-3.9 by Avra Sengupta (asengupt)

Comment 2 Worker Ant 2016-12-19 07:21:35 UTC

COMMIT: http://review.gluster.org/16112 committed in release-3.9 by Rajesh Joseph (rjoseph) 
------
commit 6e243d0c8e1f408bb648e1e8bd2d171de408f4b3
Author: Avra Sengupta <asengupt>
Date:   Fri Dec 9 15:01:40 2016 +0530

    snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.
    
    Status of the volume being exported via nfs ganesha, should be
    checked by checking if ganesha.enable is set or not, rather than
    deciding based on the errno of the stat
    
    > Reviewed-on: http://review.gluster.org/16094
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > Reviewed-by: Rajesh Joseph <rjoseph>
    
    (cherry picked from commit 74322ce58b1c949e11cb0aa72bfded0e34422157)
    
    
    Change-Id: Iaff786d9f77a2de1322ce8ccb4b80954f84d3373
    BUG: 1404101
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/16112
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Kaushal 2017-03-08 10:23:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/